* [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom
@ 2019-01-11 23:31 Evan Green
2019-01-12 3:37 ` Martin K. Petersen
0 siblings, 1 reply; 5+ messages in thread
From: Evan Green @ 2019-01-11 23:31 UTC (permalink / raw)
To: Martin K . Petersen
Cc: Douglas Anderson, Evan Green, James E.J. Bottomley,
Vinayak Holikatti, linux-scsi, linux-kernel
CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
this was the only possible PHY driver Qualcomm's UFS controller
would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
and phy-qcom-ufs is unused.
Remove the select, since for SDM845 it adds useless drivers to the
build.
Signed-off-by: Evan Green <evgreen@chromium.org>
---
drivers/scsi/ufs/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig
index 2ddbb26d9c265..6db37cf306b05 100644
--- a/drivers/scsi/ufs/Kconfig
+++ b/drivers/scsi/ufs/Kconfig
@@ -99,7 +99,6 @@ config SCSI_UFS_DWC_TC_PLATFORM
config SCSI_UFS_QCOM
tristate "QCOM specific hooks to UFS controller platform driver"
depends on SCSI_UFSHCD_PLATFORM && ARCH_QCOM
- select PHY_QCOM_UFS
help
This selects the QCOM specific additions to UFSHCD platform driver.
UFS host on QCOM needs some vendor specific configuration before
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom
2019-01-11 23:31 [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom Evan Green
@ 2019-01-12 3:37 ` Martin K. Petersen
2019-01-14 17:07 ` Doug Anderson
0 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2019-01-12 3:37 UTC (permalink / raw)
To: Evan Green
Cc: Martin K . Petersen, Douglas Anderson, James E.J. Bottomley,
Vinayak Holikatti, linux-scsi, linux-kernel
Evan,
> CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> this was the only possible PHY driver Qualcomm's UFS controller
> would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> and phy-qcom-ufs is unused.
>
> Remove the select, since for SDM845 it adds useless drivers to the
> build.
Applied to 5.1/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom
2019-01-12 3:37 ` Martin K. Petersen
@ 2019-01-14 17:07 ` Doug Anderson
2019-01-14 18:41 ` Evan Green
0 siblings, 1 reply; 5+ messages in thread
From: Doug Anderson @ 2019-01-14 17:07 UTC (permalink / raw)
To: Martin K. Petersen, Bjorn Andersson, Andy Gross, masneyb
Cc: Evan Green, James E.J. Bottomley, Vinayak Holikatti, linux-scsi,
LKML, linux-arm-msm
Hi,
On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>
>
> Evan,
>
> > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> > this was the only possible PHY driver Qualcomm's UFS controller
> > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> > and phy-qcom-ufs is unused.
> >
> > Remove the select, since for SDM845 it adds useless drivers to the
> > build.
>
> Applied to 5.1/scsi-queue.
Should this be accompanied by a change to arch/arm64/configs/defconfig
that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any
non-SDM845 devices to test on, but I'm sorta assuming they will all
break without the defconfig update?
Added a few more people (and linux-arm-msm list) to this thread in
case this matters to anyone.
-Doug
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom
2019-01-14 17:07 ` Doug Anderson
@ 2019-01-14 18:41 ` Evan Green
2019-01-14 19:11 ` Evan Green
0 siblings, 1 reply; 5+ messages in thread
From: Evan Green @ 2019-01-14 18:41 UTC (permalink / raw)
To: Doug Anderson
Cc: Martin K. Petersen, Bjorn Andersson, Andy Gross, masneyb,
James E.J. Bottomley, Vinayak Holikatti, linux-scsi, LKML,
linux-arm-msm
On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
> <martin.petersen@oracle.com> wrote:
> >
> >
> > Evan,
> >
> > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> > > this was the only possible PHY driver Qualcomm's UFS controller
> > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> > > and phy-qcom-ufs is unused.
> > >
> > > Remove the select, since for SDM845 it adds useless drivers to the
> > > build.
> >
> > Applied to 5.1/scsi-queue.
>
> Should this be accompanied by a change to arch/arm64/configs/defconfig
> that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any
> non-SDM845 devices to test on, but I'm sorta assuming they will all
> break without the defconfig update?
Right, thanks for pointing that out. I'll send out another patch to
tweak the defconfig.
-Evan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom
2019-01-14 18:41 ` Evan Green
@ 2019-01-14 19:11 ` Evan Green
0 siblings, 0 replies; 5+ messages in thread
From: Evan Green @ 2019-01-14 19:11 UTC (permalink / raw)
To: Doug Anderson
Cc: Martin K. Petersen, Bjorn Andersson, Andy Gross, masneyb,
James E.J. Bottomley, Vinayak Holikatti, linux-scsi, LKML,
linux-arm-msm
On Mon, Jan 14, 2019 at 10:41 AM Evan Green <evgreen@chromium.org> wrote:
>
> On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson <dianders@chromium.org> wrote:
> >
> > Hi,
> >
> > On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
> > <martin.petersen@oracle.com> wrote:
> > >
> > >
> > > Evan,
> > >
> > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
> > > > this was the only possible PHY driver Qualcomm's UFS controller
> > > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
> > > > and phy-qcom-ufs is unused.
> > > >
> > > > Remove the select, since for SDM845 it adds useless drivers to the
> > > > build.
> > >
> > > Applied to 5.1/scsi-queue.
> >
> > Should this be accompanied by a change to arch/arm64/configs/defconfig
> > that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any
> > non-SDM845 devices to test on, but I'm sorta assuming they will all
> > break without the defconfig update?
>
> Right, thanks for pointing that out. I'll send out another patch to
> tweak the defconfig.
Sent out at:
https://lore.kernel.org/lkml/20190114190112.167922-1-evgreen@chromium.org/T/#u
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-14 19:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 23:31 [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom Evan Green
2019-01-12 3:37 ` Martin K. Petersen
2019-01-14 17:07 ` Doug Anderson
2019-01-14 18:41 ` Evan Green
2019-01-14 19:11 ` Evan Green
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).