From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Bart Van Assche <bvanassche@acm.org>,
Lee Duncan <leeman.duncan@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Duncan <lduncan@suse.com>, Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD
Date: Mon, 07 Nov 2022 21:50:23 -0500 [thread overview]
Message-ID: <yq1k046kwyv.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <4a1da181-8a54-d2f8-6d19-d9c1982ab044@suse.de> (Hannes Reinecke's message of "Tue, 4 Oct 2022 08:00:56 +0200")
Hannes,
I have been contemplating this for a bit.
>> Has it been considered instead of introducing a blacklist flag to not
>> use the reported VPD page size if the device reports that the VPD
>> page size is zero? I am not aware of any VPD pages for which zero is
>> a valid size.
That would also be my preferred approach, I think. I haven't received
any bug reports about devices returning short VPD pages since this
change was introduced. So I think I'd prefer falling back to a
(hopefully small) default if a device returns a 0 page length.
Now, my question is which VPD pages are actually supported by this
device and how large are they?
> But pre-SPC drives will ignore the VPD bit in the inquiry size. And
> these devices do not set an additional length in the inquiry data
Can you elaborate a bit on your experience with older devices? I checked
SCSI-2 (1991) and don't see any indication this would be valid behavior
even back then.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-11-08 2:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 18:13 [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD Lee Duncan
2022-09-29 10:42 ` Martin Wilck
2022-10-02 21:16 ` Bart Van Assche
2022-10-02 22:21 ` Lee Duncan
2022-10-04 6:00 ` Hannes Reinecke
2022-11-08 2:50 ` Martin K. Petersen [this message]
2022-11-08 6:57 ` Hannes Reinecke
2022-11-21 14:53 ` Martin Wilck
2022-10-03 16:32 ` Bart Van Assche
2023-02-20 11:13 ` Srikar Dronamraju
2023-02-27 7:02 ` Hannes Reinecke
2023-03-03 9:02 ` Linux regression tracking (Thorsten Leemhuis)
2023-03-03 18:54 ` Lee Duncan
2023-03-06 22:14 ` Martin K. Petersen
2023-03-07 2:54 ` Martin K. Petersen
2023-03-07 10:32 ` Srikar Dronamraju
2023-03-07 16:33 ` Lee Duncan
2023-03-07 23:40 ` Martin K. Petersen
2023-03-08 18:41 ` Lee Duncan
2023-03-10 3:17 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1k046kwyv.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=leeman.duncan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).