From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933715AbcBQDDm (ORCPT ); Tue, 16 Feb 2016 22:03:42 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:28592 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933234AbcBQDDl (ORCPT ); Tue, 16 Feb 2016 22:03:41 -0500 To: jthumshirn@suse.de Cc: James Bottomley , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, nfont@linux.vnet.ibm.com, brking@linux.vnet.ibm.com, manoj@linux.vnet.ibm.com, Tyrel Datwyler Subject: Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines From: "Martin K. Petersen" Organization: Oracle Corporation References: <1455154348-3226-1-git-send-email-tyreld@linux.vnet.ibm.com> <1455154348-3226-4-git-send-email-tyreld@linux.vnet.ibm.com> <1455295395.2396.22.camel@HansenPartnership.com> <56BE0D7D.3050703@linux.vnet.ibm.com> Date: Tue, 16 Feb 2016 22:03:24 -0500 In-Reply-To: <56BE0D7D.3050703@linux.vnet.ibm.com> (Tyrel Datwyler's message of "Fri, 12 Feb 2016 08:51:09 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Tyrel" == Tyrel Datwyler writes: >> Is there some reason you didn't carry the review tag over from this: >> >> http://mid.gmane.org/20160204084459.GW27969@c203.arch.suse.de >> >> ? >> >> James Tyrel> The patch is slightly changed from v1. A define for AIX os type Tyrel> was added as mentioned in the cover letter v2 changes, and I Tyrel> moved the defines to the mad_adapter_info_data structure around Tyrel> the fields they apply. Johannes: Mind checking this out? https://patchwork.kernel.org/patch/8276101/ -- Martin K. Petersen Oracle Linux Engineering