From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>,
jejb@linux.ibm.com, martin.petersen@oracle.com,
dgilbert@interlog.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi_logging: print cdb into new line after opcode
Date: Fri, 22 Jan 2021 22:09:57 -0500 [thread overview]
Message-ID: <yq1mtx09wpa.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <c0c7b4cde76c9b15aad9fa213dcaeb75295763fd.camel@redhat.com> (Ewan D. Milne's message of "Fri, 22 Jan 2021 14:52:56 -0500")
Ewan,
>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01
>> 00
>>
>> Print the cdb into a new line in any case, not only when cmd_len is
>> greater than 16. The above example error will then read:
>>
>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28
>> 28 00 01 c0 09 00 00 00 08 00
>
> I'd rather we not change this.
I agree. While the current format is suboptimal, there are lots of
things out there parsing these error messages.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-01-23 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 8:39 [PATCH] scsi_logging: print cdb into new line after opcode Martin Kepplinger
2021-01-22 19:52 ` Ewan D. Milne
2021-01-23 3:09 ` Martin K. Petersen [this message]
2021-01-25 7:29 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1mtx09wpa.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=emilne@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).