From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755634AbbJUQea (ORCPT ); Wed, 21 Oct 2015 12:34:30 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32132 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319AbbJUQe2 (ORCPT ); Wed, 21 Oct 2015 12:34:28 -0400 To: Mike Snitzer Cc: Christoph Hellwig , Ming Lin , lkml , Jens Axboe , Kent Overstreet , Dongsu Park , "Martin K. Petersen" , Ming Lin , linux-nvme@lists.infradead.org Subject: Re: [PATCH v6 05/11] block: remove split code in blkdev_issue_{discard,write_same} From: "Martin K. Petersen" Organization: Oracle Corporation References: <1439363241-31772-1-git-send-email-mlin@kernel.org> <1439363241-31772-6-git-send-email-mlin@kernel.org> <20151013115011.GA6546@infradead.org> <20151014132700.GA19401@infradead.org> <20151021160232.GA5089@redhat.com> <20151021161947.GA5212@redhat.com> Date: Wed, 21 Oct 2015 12:33:07 -0400 In-Reply-To: <20151021161947.GA5212@redhat.com> (Mike Snitzer's message of "Wed, 21 Oct 2015 12:19:47 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Mike" == Mike Snitzer writes: >> That should work for all devices and for dm-thinp (and dm-cache) in >> particular will ensure that all discards that are issued will be a >> multiple of the underlying device's blocksize. Mike> Jeff Moyer pointed out having req_sects be a factor of Mike> discard_granularity makes more sense. Absolutely! -- Martin K. Petersen Oracle Linux Engineering