From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] scsi: lpfc: Fix memory leak on lcb_context
Date: Thu, 19 Nov 2020 22:17:27 -0500 [thread overview]
Message-ID: <yq1o8jswwci.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20201118141314.462471-1-colin.king@canonical.com> (Colin King's message of "Wed, 18 Nov 2020 14:13:14 +0000")
Colin,
> Currently there is an error return path that neglects to free the
> allocation for lcb_context. Fix this by adding a new error free exit
> path that kfree's lcb_context before returning. Use this new kfree
> exit path in another exit error path that also kfree's the same
> object, allowing a line of code to be removed.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-11-20 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 14:13 [PATCH][next] scsi: lpfc: Fix memory leak on lcb_context Colin King
2020-11-19 20:58 ` James Smart
2020-11-20 3:17 ` Martin K. Petersen [this message]
2020-11-24 3:57 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1o8jswwci.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).