* [PATCH] qla2xxx: Use constant when it is known.
@ 2020-09-21 11:23 Pavel Machek
2020-10-07 13:29 ` Himanshu Madhani
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pavel Machek @ 2020-09-21 11:23 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]
Directly return constant when it is known, to make code easier to
understand.
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 90bbc61f361b..248197e9e8ea 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -530,7 +530,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
fc_port_t *fcport;
struct srb_iocb *nvme;
struct scsi_qla_host *vha;
- int rval = -ENODEV;
+ int rval;
srb_t *sp;
struct qla_qpair *qpair = hw_queue_handle;
struct nvme_private *priv = fd->private;
@@ -538,14 +538,14 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
if (!priv) {
/* nvme association has been torn down */
- return rval;
+ return -ENODEV;
}
fcport = qla_rport->fcport;
if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
(fcport && fcport->deleted))
- return rval;
+ return -ENODEV;
vha = fcport->vha;
/*
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qla2xxx: Use constant when it is known.
2020-09-21 11:23 [PATCH] qla2xxx: Use constant when it is known Pavel Machek
@ 2020-10-07 13:29 ` Himanshu Madhani
2020-10-08 2:12 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2020-10-07 13:29 UTC (permalink / raw)
To: Pavel Machek
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
> On Sep 21, 2020, at 6:23 AM, Pavel Machek <pavel@denx.de> wrote:
>
> Directly return constant when it is known, to make code easier to
> understand.
>
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
>
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 90bbc61f361b..248197e9e8ea 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -530,7 +530,7 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
> fc_port_t *fcport;
> struct srb_iocb *nvme;
> struct scsi_qla_host *vha;
> - int rval = -ENODEV;
> + int rval;
> srb_t *sp;
> struct qla_qpair *qpair = hw_queue_handle;
> struct nvme_private *priv = fd->private;
> @@ -538,14 +538,14 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
>
> if (!priv) {
> /* nvme association has been torn down */
> - return rval;
> + return -ENODEV;
> }
>
> fcport = qla_rport->fcport;
>
> if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
> (fcport && fcport->deleted))
> - return rval;
> + return -ENODEV;
>
> vha = fcport->vha;
> /*
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qla2xxx: Use constant when it is known.
2020-09-21 11:23 [PATCH] qla2xxx: Use constant when it is known Pavel Machek
2020-10-07 13:29 ` Himanshu Madhani
@ 2020-10-08 2:12 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-10-08 2:12 UTC (permalink / raw)
To: Pavel Machek
Cc: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
Pavel,
> Directly return constant when it is known, to make code easier to
> understand.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qla2xxx: Use constant when it is known.
2020-09-21 11:23 [PATCH] qla2xxx: Use constant when it is known Pavel Machek
2020-10-07 13:29 ` Himanshu Madhani
2020-10-08 2:12 ` Martin K. Petersen
@ 2020-10-13 22:42 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-10-13 22:42 UTC (permalink / raw)
To: linux-kernel, njavali, Pavel Machek, jejb, linux-scsi,
GR-QLogic-Storage-Upstream
Cc: Martin K . Petersen
On Mon, 21 Sep 2020 13:23:40 +0200, Pavel Machek wrote:
> Directly return constant when it is known, to make code easier to
> understand.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Use constant when it is known
https://git.kernel.org/mkp/scsi/c/b994718760fa
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-13 22:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 11:23 [PATCH] qla2xxx: Use constant when it is known Pavel Machek
2020-10-07 13:29 ` Himanshu Madhani
2020-10-08 2:12 ` Martin K. Petersen
2020-10-13 22:42 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).