From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751474AbcDOU1J (ORCPT ); Fri, 15 Apr 2016 16:27:09 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50642 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbcDOU1H (ORCPT ); Fri, 15 Apr 2016 16:27:07 -0400 To: Dan Carpenter Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Bart Van Assche , Johannes Thumshirn , Ewan Milne , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg() From: "Martin K. Petersen" Organization: Oracle Corporation References: <20160414182034.GA32469@mwanda> Date: Fri, 15 Apr 2016 16:26:51 -0400 In-Reply-To: <20160414182034.GA32469@mwanda> (Dan Carpenter's message of "Thu, 14 Apr 2016 21:20:34 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Dan" == Dan Carpenter writes: Dan> It's possible to use "err" without initializing it. If it happens Dan> to be a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Dan> Van Assche pointed out that we should probably re-initialize it for Dan> every iteration through the retry loop. Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering