* [PATCH] scsi: csiostor: Return value not required for csio_dfs_destroy.
@ 2019-10-28 19:42 Saurav Girepunje
2019-11-02 0:22 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2019-10-28 19:42 UTC (permalink / raw)
To: jejb, martin.petersen, varun, emilne, saurav.girepunje, gregkh,
hare, linux-scsi, linux-kernel
Cc: saurav.girepunje
Only csio_hw_free() calling csio_dfs_destroy() and it is not
checking return value. So remove the return from csio_dfs_destroy().
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/scsi/csiostor/csio_init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c
index a6dd704d7f2d..28b77fa8b015 100644
--- a/drivers/scsi/csiostor/csio_init.c
+++ b/drivers/scsi/csiostor/csio_init.c
@@ -154,13 +154,11 @@ csio_dfs_create(struct csio_hw *hw)
/*
* csio_dfs_destroy - Destroys per-hw debugfs.
*/
-static int
+static void
csio_dfs_destroy(struct csio_hw *hw)
{
if (hw->debugfs_root)
debugfs_remove_recursive(hw->debugfs_root);
-
- return 0;
}
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: csiostor: Return value not required for csio_dfs_destroy.
2019-10-28 19:42 [PATCH] scsi: csiostor: Return value not required for csio_dfs_destroy Saurav Girepunje
@ 2019-11-02 0:22 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-11-02 0:22 UTC (permalink / raw)
To: Saurav Girepunje
Cc: jejb, martin.petersen, varun, emilne, gregkh, hare, linux-scsi,
linux-kernel, saurav.girepunje
Saurav,
> Only csio_hw_free() calling csio_dfs_destroy() and it is not
> checking return value. So remove the return from csio_dfs_destroy().
Applied to 5.5/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-02 0:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 19:42 [PATCH] scsi: csiostor: Return value not required for csio_dfs_destroy Saurav Girepunje
2019-11-02 0:22 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).