From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Shaohua Li <shli@fb.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<axboe@fb.com>, <sitsofe@yahoo.com>, <snitzer@redhat.com>,
<hch@infradead.org>, <Kernel-team@fb.com>
Subject: Re: [PATCH V2] block: correctly fallback for zeroout
Date: Fri, 10 Jun 2016 21:49:44 -0400 [thread overview]
Message-ID: <yq1shwkfq9z.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20160610025435.GA48899@shli-mbp.local> (Shaohua Li's message of "Thu, 9 Jun 2016 19:54:36 -0700")
>>>>> "Shaohua" == Shaohua Li <shli@fb.com> writes:
Shaohua,
>> What does the extra io_err buy us? Just have this function return an
>> error. And then in blkdev_issue_discard if you get -EOPNOTSUPP you
>> special case it there.
Shaohua> The __blkdev_issue_discard returns -EOPNOTSUPP if disk doesn't
Shaohua> support discard. in that case, blkdev_issue_discard doesn't
Shaohua> return 0. blkdev_issue_discard only returns 0 if IO error is
Shaohua> -EOPNOTSUPP.
Oh, I see. The sanity checks are now in __blkdev_issue_discard() so
there is no way to distinguish between -EOPNOTSUPP and the other
-EOPNOTSUPP. *sigh*
I am OK with your patch as a stable fix but this really needs to be
fixed up properly.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-06-11 1:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 22:33 [PATCH V2] block: correctly fallback for zeroout Shaohua Li
2016-06-07 4:50 ` Sitsofe Wheeler
2016-06-07 14:58 ` Shaohua Li
2016-06-15 21:26 ` Sitsofe Wheeler
2016-06-10 2:04 ` Martin K. Petersen
2016-06-10 2:54 ` Shaohua Li
2016-06-11 1:49 ` Martin K. Petersen [this message]
2016-06-13 8:20 ` Christoph Hellwig
2016-06-14 18:36 ` Mike Snitzer
2016-06-15 2:30 ` Martin K. Petersen
2016-06-15 2:40 ` Mike Snitzer
2016-06-15 2:14 ` Martin K. Petersen
2016-06-15 21:24 ` Sitsofe Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1shwkfq9z.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
--cc=sitsofe@yahoo.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).