From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC17C43387 for ; Sat, 12 Jan 2019 02:06:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22CED2084E for ; Sat, 12 Jan 2019 02:06:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="oiVF2fHO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726498AbfALCGY (ORCPT ); Fri, 11 Jan 2019 21:06:24 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:35156 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbfALCGY (ORCPT ); Fri, 11 Jan 2019 21:06:24 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id x0C2618E084971; Sat, 12 Jan 2019 02:06:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=i4emJfhY5esxDaGrfFa5KlZPJkM1H2p4Zwd6svnMOvQ=; b=oiVF2fHO2dy72cx61LYNGORo6DpoKru09sk2LDy35tNYy783Ocg2hj++s3IUiJzhe523 b8zvDm1sziVqWNZZvRa1dJZB0heutSHF/ckgZqkuRmf1EpLnylvc9oNKDaWTUGZrdsUD VvyPAUhKMpwTfzHLBWFi6YDd9tUcrwPUDh5IMvPcxAFBLt0AcUfYxG5oeAekSf9nifGS WO7yaJRTGgc3QZMapLEmHHM93WG0LGghZ9mw/W4BUacZ/zb2Tkr0yWkUMG1+BKUxBP3w /ytHbNffzhWDS9X2xdK4BdsdkrY1lsbmvrzhJ6XffXyyx4HxDocWp6Xq1rCeiREgBfIh Wg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2ptn7rfjc1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 12 Jan 2019 02:06:01 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x0C260dm009831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 12 Jan 2019 02:06:00 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x0C25xwk018010; Sat, 12 Jan 2019 02:05:59 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 11 Jan 2019 18:05:59 -0800 To: Nilesh Javali Cc: "Gustavo A. R. Silva" , "Dept-Eng QLogic Storage Upstream" , "James E.J. Bottomley" , "Martin K. Petersen" , "linux-scsi\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch fall-through From: "Martin K. Petersen" Organization: Oracle Corporation References: Date: Fri, 11 Jan 2019 21:05:56 -0500 In-Reply-To: (Nilesh Javali's message of "Mon, 24 Dec 2018 09:01:26 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9133 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=537 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901120014 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nilesh, >>In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>where we are expecting to fall through. >> >>Notice that, in this particular case, I replaced "allow fall-through" >>with a "fall through" annotation, which is what GCC is expecting to >>find. Applied to 5.1/scsi-queue. Thanks, Gustavo. -- Martin K. Petersen Oracle Linux Engineering