From: Sven Schnelle <svens@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
rafael@kernel.org, viresh.kumar@linaro.org, mingo@kernel.org,
x86@kernel.org, mark.rutland@arm.com, will@kernel.org,
linux-kernel@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 1/2] sched/idle: Fix arch_cpu_idle() vs tracing
Date: Tue, 01 Dec 2020 12:12:18 +0100 [thread overview]
Message-ID: <yt9d4kl56ar1.fsf@linux.ibm.com> (raw)
In-Reply-To: <20201201110209.GQ3040@hirez.programming.kicks-ass.net> (Peter Zijlstra's message of "Tue, 1 Dec 2020 12:02:09 +0100")
Peter Zijlstra <peterz@infradead.org> writes:
> On Mon, Nov 30, 2020 at 01:00:03PM -0800, Guenter Roeck wrote:
>> On Fri, Nov 20, 2020 at 12:41:46PM +0100, Peter Zijlstra wrote:
>> > We call arch_cpu_idle() with RCU disabled, but then use
>> > local_irq_{en,dis}able(), which invokes tracing, which relies on RCU.
>> >
>> > Switch all arch_cpu_idle() implementations to use
>> > raw_local_irq_{en,dis}able() and carefully manage the
>> > lockdep,rcu,tracing state like we do in entry.
>> >
>> > (XXX: we really should change arch_cpu_idle() to not return with
>> > interrupts enabled)
>> >
>>
>> Has this patch been tested on s390 ? Reason for asking is that it causes
>> all my s390 emulations to crash. Reverting it fixes the problem.
>
> My understanding is that it changes the error on s390. Previously it
> would complain about the local_irq_enable() in arch_cpu_idle(), now it
> complains when taking an interrupt during idle.
The errors on s390 all were fixed in the meantime. I cannot say which
patch fixed it, but we haven't seen any warning in our internal CI
during the last weeks. So reverting the patch would likely fix the issue
for us.
s390 is likely to switch to generic entry with the next merge window (im
working on it), so all that stuff will be easier than.
next prev parent reply other threads:[~2020-12-01 11:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 11:41 [PATCH 0/2] More RCU vs idle fixes Peter Zijlstra
2020-11-20 11:41 ` [PATCH 1/2] sched/idle: Fix arch_cpu_idle() vs tracing Peter Zijlstra
2020-11-20 12:39 ` Mark Rutland
2020-11-25 13:57 ` [tip: locking/urgent] " tip-bot2 for Peter Zijlstra
2020-11-30 21:00 ` [PATCH 1/2] " Guenter Roeck
2020-12-01 11:02 ` Peter Zijlstra
2020-12-01 11:12 ` Sven Schnelle [this message]
2020-12-01 11:56 ` Sven Schnelle
2020-12-01 12:52 ` Peter Zijlstra
2020-12-01 13:06 ` Guenter Roeck
2020-12-01 13:38 ` Will Deacon
2020-12-01 14:51 ` Peter Zijlstra
2020-11-20 11:41 ` [PATCH 2/2] intel_idle: Fix intel_idle() " Peter Zijlstra
2020-11-23 10:26 ` Rafael J. Wysocki
2020-11-23 13:46 ` Peter Zijlstra
2020-11-23 13:54 ` Rafael J. Wysocki
2020-11-23 14:35 ` Peter Zijlstra
2020-11-23 14:54 ` Rafael J. Wysocki
2020-11-25 13:57 ` [tip: locking/urgent] " tip-bot2 for Peter Zijlstra
2020-11-24 13:47 ` [PATCH 0/2] More RCU vs idle fixes Sven Schnelle
2020-11-24 14:18 ` Peter Zijlstra
2020-11-24 14:23 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yt9d4kl56ar1.fsf@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).