From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760210AbbA2L3j (ORCPT ); Thu, 29 Jan 2015 06:29:39 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:51908 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754434AbbA2L3g convert rfc822-to-8bit (ORCPT ); Thu, 29 Jan 2015 06:29:36 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Arnd Bergmann Cc: David Miller , behanw@converseincode.com, sathya.perla@emulex.com, ajit.khaparde@emulex.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, subbu.seetharaman@emulex.com Subject: Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE() References: <1422495374-22835-1-git-send-email-behanw@converseincode.com> <20150128.224228.1533046356464752424.davem@davemloft.net> <3392784.h8cmHX9fyr@wuerfel> Date: Thu, 29 Jan 2015 11:29:32 +0000 In-Reply-To: <3392784.h8cmHX9fyr@wuerfel> (Arnd Bergmann's message of "Thu, 29 Jan 2015 10:10:48 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > On Wednesday 28 January 2015 22:42:28 David Miller wrote: >> From: Behan Webster >> Date: Wed, 28 Jan 2015 17:36:14 -0800 >> >> > Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang. >> > >> > Signed-off-by: Behan Webster >> > Suggested-by: Arnd Bergmann >> >> Why are you removing the device table? > > Behan took a patch that I did earlier and split it up to add descriptions. > The patch is correct, but he either misunderstood or misexpressed the > intention. > > This driver has two identical lines that both say > > MODULE_DEVICE_TABLE(pci, be_dev_ids); > > I don't remember the exact symptom, but llvm/clang trips over this, while gcc > silently ignores the second one. GCC is probably being "helpful" and allowing multiple identical definitions even though the C spec does not. Obviously all but one should go away. No need to mention llvm, IMO. -- Måns Rullgård mans@mansr.com