From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from deadmen.hmeau.com (helcar.hmeau.com [216.24.177.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 856DA3FCB for ; Fri, 17 Sep 2021 03:58:32 +0000 (UTC) Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1mR4Or-000695-Op; Fri, 17 Sep 2021 11:18:53 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1mR4Oq-0001jI-1W; Fri, 17 Sep 2021 11:18:52 +0800 Date: Fri, 17 Sep 2021 11:18:52 +0800 From: Herbert Xu To: Nathan Chancellor Cc: "David S. Miller" , Tianjia Zhang , Nick Desaulniers , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, llvm@lists.linux.dev Subject: Re: [PATCH] crypto: sm4 - Do not change section of ck and sbox Message-ID: <20210917031851.GB6559@gondor.apana.org.au> References: <20210825203859.416449-1-nathan@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825203859.416449-1-nathan@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) On Wed, Aug 25, 2021 at 01:38:59PM -0700, Nathan Chancellor wrote: > When building with clang and GNU as, there is a warning about ignored > changed section attributes: > > /tmp/sm4-c916c8.s: Assembler messages: > /tmp/sm4-c916c8.s:677: Warning: ignoring changed section attributes for > .data..cacheline_aligned > > "static const" places the data in .rodata but __cacheline_aligned has > the section attribute to place it in .data..cacheline_aligned, in > addition to the aligned attribute. > > To keep the alignment but avoid attempting to change sections, use the > ____cacheline_aligned attribute, which is just the aligned attribute. > > Fixes: 2b31277af577 ("crypto: sm4 - create SM4 library based on sm4 generic code") > Link: https://github.com/ClangBuiltLinux/linux/issues/1441 > Signed-off-by: Nathan Chancellor > --- > lib/crypto/sm4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt