* [PATCH v2] md/raid5: remove unused working_disks variable
@ 2023-03-27 13:23 Tom Rix
2023-03-28 23:17 ` Song Liu
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-27 13:23 UTC (permalink / raw)
To: song, nathan, ndesaulniers; +Cc: linux-raid, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/md/raid5.c:7719:6: error: variable 'working_disks'
set but not used [-Werror,-Wunused-but-set-variable]
int working_disks = 0;
^
This variable is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
v2: remove brances
---
drivers/md/raid5.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 7b820b81d8c2..812a12e3e41a 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7716,7 +7716,6 @@ static void raid5_set_io_opt(struct r5conf *conf)
static int raid5_run(struct mddev *mddev)
{
struct r5conf *conf;
- int working_disks = 0;
int dirty_parity_disks = 0;
struct md_rdev *rdev;
struct md_rdev *journal_dev = NULL;
@@ -7912,10 +7911,8 @@ static int raid5_run(struct mddev *mddev)
pr_warn("md: cannot handle concurrent replacement and reshape.\n");
goto abort;
}
- if (test_bit(In_sync, &rdev->flags)) {
- working_disks++;
+ if (test_bit(In_sync, &rdev->flags))
continue;
- }
/* This disc is not fully in-sync. However if it
* just stored parity (beyond the recovery_offset),
* when we don't need to be concerned about the
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] md/raid5: remove unused working_disks variable
2023-03-27 13:23 [PATCH v2] md/raid5: remove unused working_disks variable Tom Rix
@ 2023-03-28 23:17 ` Song Liu
0 siblings, 0 replies; 2+ messages in thread
From: Song Liu @ 2023-03-28 23:17 UTC (permalink / raw)
To: Tom Rix; +Cc: nathan, ndesaulniers, linux-raid, linux-kernel, llvm
On Mon, Mar 27, 2023 at 6:23 AM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/md/raid5.c:7719:6: error: variable 'working_disks'
> set but not used [-Werror,-Wunused-but-set-variable]
> int working_disks = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied to md-next, with Yu Kuai's Reviewed-by.
Thanks,
Song
> ---
> v2: remove brances
> ---
> drivers/md/raid5.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 7b820b81d8c2..812a12e3e41a 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -7716,7 +7716,6 @@ static void raid5_set_io_opt(struct r5conf *conf)
> static int raid5_run(struct mddev *mddev)
> {
> struct r5conf *conf;
> - int working_disks = 0;
> int dirty_parity_disks = 0;
> struct md_rdev *rdev;
> struct md_rdev *journal_dev = NULL;
> @@ -7912,10 +7911,8 @@ static int raid5_run(struct mddev *mddev)
> pr_warn("md: cannot handle concurrent replacement and reshape.\n");
> goto abort;
> }
> - if (test_bit(In_sync, &rdev->flags)) {
> - working_disks++;
> + if (test_bit(In_sync, &rdev->flags))
> continue;
> - }
> /* This disc is not fully in-sync. However if it
> * just stored parity (beyond the recovery_offset),
> * when we don't need to be concerned about the
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-28 23:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-27 13:23 [PATCH v2] md/raid5: remove unused working_disks variable Tom Rix
2023-03-28 23:17 ` Song Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).