* [PATCH] dmaengine: tegra-apb: remove unused tdma_read function
@ 2023-03-22 12:10 Tom Rix
2023-03-22 13:46 ` Jon Hunter
2023-03-31 12:21 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-22 12:10 UTC (permalink / raw)
To: ldewangan, jonathanh, vkoul, thierry.reding, nathan, ndesaulniers
Cc: dmaengine, linux-tegra, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
'tdma_read' [-Werror,-Wunused-function]
static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
^
This function is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/dma/tegra20-apb-dma.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index eaafcbe4ca94..cc6b91f48979 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -233,11 +233,6 @@ static inline void tdma_write(struct tegra_dma *tdma, u32 reg, u32 val)
writel(val, tdma->base_addr + reg);
}
-static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
-{
- return readl(tdma->base_addr + reg);
-}
-
static inline void tdc_write(struct tegra_dma_channel *tdc,
u32 reg, u32 val)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: tegra-apb: remove unused tdma_read function
2023-03-22 12:10 [PATCH] dmaengine: tegra-apb: remove unused tdma_read function Tom Rix
@ 2023-03-22 13:46 ` Jon Hunter
2023-03-31 12:21 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Jon Hunter @ 2023-03-22 13:46 UTC (permalink / raw)
To: Tom Rix, ldewangan, vkoul, thierry.reding, nathan, ndesaulniers
Cc: dmaengine, linux-tegra, linux-kernel, llvm
On 22/03/2023 12:10, Tom Rix wrote:
> clang with W=1 reports
> drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
> 'tdma_read' [-Werror,-Wunused-function]
> static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/dma/tegra20-apb-dma.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index eaafcbe4ca94..cc6b91f48979 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -233,11 +233,6 @@ static inline void tdma_write(struct tegra_dma *tdma, u32 reg, u32 val)
> writel(val, tdma->base_addr + reg);
> }
>
> -static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
> -{
> - return readl(tdma->base_addr + reg);
> -}
> -
> static inline void tdc_write(struct tegra_dma_channel *tdc,
> u32 reg, u32 val)
> {
Thanks!
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: tegra-apb: remove unused tdma_read function
2023-03-22 12:10 [PATCH] dmaengine: tegra-apb: remove unused tdma_read function Tom Rix
2023-03-22 13:46 ` Jon Hunter
@ 2023-03-31 12:21 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-03-31 12:21 UTC (permalink / raw)
To: Tom Rix
Cc: ldewangan, jonathanh, thierry.reding, nathan, ndesaulniers,
dmaengine, linux-tegra, linux-kernel, llvm
On 22-03-23, 08:10, Tom Rix wrote:
> clang with W=1 reports
> drivers/dma/tegra20-apb-dma.c:236:19: error: unused function
> 'tdma_read' [-Werror,-Wunused-function]
> static inline u32 tdma_read(struct tegra_dma *tdma, u32 reg)
> ^
> This function is not used so remove it.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 12:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 12:10 [PATCH] dmaengine: tegra-apb: remove unused tdma_read function Tom Rix
2023-03-22 13:46 ` Jon Hunter
2023-03-31 12:21 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).