From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EFFB2CA7 for ; Sun, 25 Sep 2022 23:18:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29410C43150 for ; Sun, 25 Sep 2022 23:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664147920; bh=ir9kdaG2LaaAh6q3B/+kD0K7jgZwdQEk7RxO73YXov8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=C6XHzStZMc34QAD1pUX5CZOj2iU/Xp8QgMlsGJ+JZJuiRN0ByXBaONRvBlamch0Ma tjA9bWK08q4nCunFBLTtCLYi9vxzDS+mA3bLG0gaVmJwXh/ukCZRq6C+H92QOBExgQ oKW5kSd9uZhha8Xy9WB9rmXoDSHbDM5MX0kGJ3RM9f3rP8ndFTqNkzMsbE6eNd4Eqy Rr8/NHSryP9ma+eeCjy+/wqgXi2TfdZZMmNtuXf8cj0m7QIk5wXUlajLGngXmiY77S CGnwFYJwj+HKgvxYgre5zBh5EEsreoXheuPiGAGmSEOxITXc1sGkzHgXkOL+LdAWk5 eGAuEFfbyxM5w== Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-127ba06d03fso7234303fac.3 for ; Sun, 25 Sep 2022 16:18:40 -0700 (PDT) X-Gm-Message-State: ACrzQf3xn65a4HFPFFgp97JJdgIJdIsImWbMc6aL0cygp1GgyWosFlWR HoaDMwNvhZyo39Wh5gMSoIruDCZE5I8KNWJeSUQ= X-Google-Smtp-Source: AMsMyM5En5NGgLYHFu5c/5LTPvS4iDYtENMXq3gobkQCiXjCYHqIzdAuJ14JOjvxpya8Hqmy0rIjUt08Rfjuo7MzuhY= X-Received: by 2002:a05:6870:a78e:b0:12b:542b:e5b2 with SMTP id x14-20020a056870a78e00b0012b542be5b2mr17385757oao.112.1664147919201; Sun, 25 Sep 2022 16:18:39 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220925175356.681-1-jszhang@kernel.org> <20220925175356.681-2-jszhang@kernel.org> In-Reply-To: <20220925175356.681-2-jszhang@kernel.org> From: Guo Ren Date: Mon, 26 Sep 2022 07:18:26 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] riscv: remove extra level wrappers of trace_hardirqs_{on,off} To: Jisheng Zhang Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Reviewed-by: Guo Ren I would involve the patch in the generic entry series, okay? On Mon, Sep 26, 2022 at 2:03 AM Jisheng Zhang wrote: > > Since riscv is converted to generic entry, there's no need for the > extra wrappers of trace_hardirqs_{on,off}. > > Tested with llvm + irqsoff. > > Signed-off-by: Jisheng Zhang > --- > arch/riscv/kernel/Makefile | 2 -- > arch/riscv/kernel/trace_irq.c | 27 --------------------------- > arch/riscv/kernel/trace_irq.h | 11 ----------- > 3 files changed, 40 deletions(-) > delete mode 100644 arch/riscv/kernel/trace_irq.c > delete mode 100644 arch/riscv/kernel/trace_irq.h > > diff --git a/arch/riscv/kernel/Makefile b/arch/riscv/kernel/Makefile > index 01da14e21019..11ee206cc235 100644 > --- a/arch/riscv/kernel/Makefile > +++ b/arch/riscv/kernel/Makefile > @@ -69,8 +69,6 @@ obj-$(CONFIG_CPU_PM) += suspend_entry.o suspend.o > obj-$(CONFIG_FUNCTION_TRACER) += mcount.o ftrace.o > obj-$(CONFIG_DYNAMIC_FTRACE) += mcount-dyn.o > > -obj-$(CONFIG_TRACE_IRQFLAGS) += trace_irq.o > - > obj-$(CONFIG_PERF_EVENTS) += perf_callchain.o > obj-$(CONFIG_HAVE_PERF_REGS) += perf_regs.o > obj-$(CONFIG_RISCV_SBI) += sbi.o > diff --git a/arch/riscv/kernel/trace_irq.c b/arch/riscv/kernel/trace_irq.c > deleted file mode 100644 > index 095ac976d7da..000000000000 > --- a/arch/riscv/kernel/trace_irq.c > +++ /dev/null > @@ -1,27 +0,0 @@ > -// SPDX-License-Identifier: GPL-2.0 > -/* > - * Copyright (C) 2022 Changbin Du > - */ > - > -#include > -#include > -#include "trace_irq.h" > - > -/* > - * trace_hardirqs_on/off require the caller to setup frame pointer properly. > - * Otherwise, CALLER_ADDR1 might trigger an pagging exception in kernel. > - * Here we add one extra level so they can be safely called by low > - * level entry code which $fp is used for other purpose. > - */ > - > -void __trace_hardirqs_on(void) > -{ > - trace_hardirqs_on(); > -} > -NOKPROBE_SYMBOL(__trace_hardirqs_on); > - > -void __trace_hardirqs_off(void) > -{ > - trace_hardirqs_off(); > -} > -NOKPROBE_SYMBOL(__trace_hardirqs_off); > diff --git a/arch/riscv/kernel/trace_irq.h b/arch/riscv/kernel/trace_irq.h > deleted file mode 100644 > index 99fe67377e5e..000000000000 > --- a/arch/riscv/kernel/trace_irq.h > +++ /dev/null > @@ -1,11 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > -/* > - * Copyright (C) 2022 Changbin Du > - */ > -#ifndef __TRACE_IRQ_H > -#define __TRACE_IRQ_H > - > -void __trace_hardirqs_on(void); > -void __trace_hardirqs_off(void); > - > -#endif /* __TRACE_IRQ_H */ > -- > 2.34.1 > -- Best Regards Guo Ren