From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD8BE7B for ; Sat, 24 Sep 2022 01:35:27 +0000 (UTC) Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 28O1ZLnq003584 for ; Sat, 24 Sep 2022 10:35:21 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 28O1ZLnq003584 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1663983322; bh=/eLm7kKAZKPCAlDhAPCPjGLOw0pwSMAx5ayENfiXi90=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=z3W5UjEM36Hd+teTYWabSF73H+Epg+dz36is+jLAPjj8t18qdKsxShsG57qr0TQvO 7VLhRx+FKaYdnVYti01RvqXyQ9kEOP0LKP5YgPSjmXcf+5QN3oFeFMHD0DS4pSgND0 SrxKIi7LF2yMqMvhd9nC0uzb4evLY8TmuoQsT8YaYBOqHz1g1Msf66qPvglqF4XFIy jsl5oi5hLeUaval+kt6QGWO4LkSfg1UIeOntbV4U2qojgUH0w8TgvV3GGk0rt5zKf2 yz6O+Vh7H3bbIMtlRkOE+Ga708O/SWCz/bNk39Tav5XDtt+4Mw8WIo5zhFPqvsgLAo 2ZWffF4NmyC3A== X-Nifty-SrcIP: [209.85.160.41] Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1278a61bd57so2509615fac.7 for ; Fri, 23 Sep 2022 18:35:21 -0700 (PDT) X-Gm-Message-State: ACrzQf17bFAWVWPdtff9k1xdYFw2i4GDsBjPuVwThJn40J3P30u4P0Rk Ee161UEo7wr0pLR146uSSpszS+RrmJyEAFfp0Ok= X-Google-Smtp-Source: AMsMyM7jDHG6fhLgJft9ukvYkQPpcaymaIhsRbZ8UWBkTjR00kGt1uhvttwYCbOEb54mnP9okRPMqipDdmwDGit90Zc= X-Received: by 2002:a05:6870:3103:b0:12d:5b7b:e6f2 with SMTP id v3-20020a056870310300b0012d5b7be6f2mr12103882oaa.194.1663983320733; Fri, 23 Sep 2022 18:35:20 -0700 (PDT) Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220919173030.3726922-1-ndesaulniers@google.com> In-Reply-To: <20220919173030.3726922-1-ndesaulniers@google.com> From: Masahiro Yamada Date: Sat, 24 Sep 2022 10:34:43 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4] Makefile.debug: set -g unconditional on CONFIG_DEBUG_INFO_SPLIT To: Nick Desaulniers Cc: Michal Marek , Linux Kbuild mailing list , Linux Kernel Mailing List , clang-built-linux , Andi Kleen , Dmitrii Bundin , Fangrui Song , Nathan Chancellor Content-Type: text/plain; charset="UTF-8" On Tue, Sep 20, 2022 at 2:30 AM Nick Desaulniers wrote: > > Dmitrii, Fangrui, and Mashahiro note: > > Before GCC 11 and Clang 12 -gsplit-dwarf implicitly uses -g2. > > Fix CONFIG_DEBUG_INFO_SPLIT for gcc-11+ & clang-12+ which now need -g > specified in order for -gsplit-dwarf to work at all. > > -gsplit-dwarf has been mutually exclusive with -g since support for > CONFIG_DEBUG_INFO_SPLIT was introduced in > commit 866ced950bcd ("kbuild: Support split debug info v4") > I don't think it ever needed to be. > > Link: https://lore.kernel.org/lkml/20220815013317.26121-1-dmitrii.bundin.a@gmail.com/ > Link: https://lore.kernel.org/lkml/CAK7LNARPAmsJD5XKAw7m_X2g7Fi-CAAsWDQiP7+ANBjkg7R7ng@mail.gmail.com/ > Link: https://reviews.llvm.org/D80391 > Cc: Andi Kleen > Reported-by: Dmitrii Bundin > Reported-by: Fangrui Song > Reported-by: Masahiro Yamada > Suggested-by: Dmitrii Bundin > Reviewed-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers > --- Applied to linux-kbuild/fixes. Thanks. > Changes v3 -> v4: > * Split into its own patch; we don't have any out of line assembler > files using .debug_* or .cfi_* directives that would produce > meaningful debug info in .dwo files. > > scripts/Makefile.debug | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/scripts/Makefile.debug b/scripts/Makefile.debug > index 9f39b0130551..26d6a9d97a20 100644 > --- a/scripts/Makefile.debug > +++ b/scripts/Makefile.debug > @@ -1,9 +1,7 @@ > -DEBUG_CFLAGS := > +DEBUG_CFLAGS := -g > > ifdef CONFIG_DEBUG_INFO_SPLIT > DEBUG_CFLAGS += -gsplit-dwarf > -else > -DEBUG_CFLAGS += -g > endif > > ifndef CONFIG_AS_IS_LLVM > -- > 2.37.3.968.ga6b4b080e4-goog > -- Best Regards Masahiro Yamada