* [PATCH] bcma: remove unused mips_read32 function
@ 2023-03-24 19:06 Tom Rix
2023-03-26 9:37 ` Simon Horman
2023-03-31 15:05 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-03-24 19:06 UTC (permalink / raw)
To: zajec5, nathan, ndesaulniers; +Cc: linux-wireless, linux-kernel, llvm, Tom Rix
clang with W=1 reports
drivers/bcma/driver_mips.c:49:19: error: unused function
'mips_read32' [-Werror,-Wunused-function]
static inline u32 mips_read32(struct bcma_drv_mips *mcore,
^
This function is not used so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/bcma/driver_mips.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
index 4f01e6b17bb9..9be0806eb033 100644
--- a/drivers/bcma/driver_mips.c
+++ b/drivers/bcma/driver_mips.c
@@ -46,12 +46,6 @@ static inline bool bcma_core_mips_bcm5357b0_quirk(struct bcma_device *dev)
dev->id.id == BCMA_CORE_USB20_HOST;
}
-static inline u32 mips_read32(struct bcma_drv_mips *mcore,
- u16 offset)
-{
- return bcma_read32(mcore->core, offset);
-}
-
static u32 bcma_core_mips_irqflag(struct bcma_device *dev)
{
u32 flag;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bcma: remove unused mips_read32 function
2023-03-24 19:06 [PATCH] bcma: remove unused mips_read32 function Tom Rix
@ 2023-03-26 9:37 ` Simon Horman
2023-03-31 15:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-03-26 9:37 UTC (permalink / raw)
To: Tom Rix; +Cc: zajec5, nathan, ndesaulniers, linux-wireless, linux-kernel, llvm
On Fri, Mar 24, 2023 at 03:06:47PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/bcma/driver_mips.c:49:19: error: unused function
> 'mips_read32' [-Werror,-Wunused-function]
> static inline u32 mips_read32(struct bcma_drv_mips *mcore,
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bcma: remove unused mips_read32 function
2023-03-24 19:06 [PATCH] bcma: remove unused mips_read32 function Tom Rix
2023-03-26 9:37 ` Simon Horman
@ 2023-03-31 15:05 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-03-31 15:05 UTC (permalink / raw)
To: Tom Rix
Cc: zajec5, nathan, ndesaulniers, linux-wireless, linux-kernel, llvm,
Tom Rix
Tom Rix <trix@redhat.com> wrote:
> clang with W=1 reports
> drivers/bcma/driver_mips.c:49:19: error: unused function
> 'mips_read32' [-Werror,-Wunused-function]
> static inline u32 mips_read32(struct bcma_drv_mips *mcore,
> ^
> This function is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Patch applied to wireless-next.git, thanks.
21898a40b2f8 bcma: remove unused mips_read32 function
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230324190647.2654293-1-trix@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-31 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24 19:06 [PATCH] bcma: remove unused mips_read32 function Tom Rix
2023-03-26 9:37 ` Simon Horman
2023-03-31 15:05 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).