From: Muchun Song <songmuchun@bytedance.com>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: Feiyang Chen <chris.chenfeiyang@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
Feiyang Chen <chenfeiyang@loongson.cn>,
loongarch@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>,
linux- stable <stable@vger.kernel.org>
Subject: Re: [External] Re: [PATCH] page-flags.h: Fix a missing header include of static_keys.h
Date: Sat, 25 Jun 2022 19:16:46 +0800 [thread overview]
Message-ID: <CAMZfGtVq0VwMETGdzAXLkjes8W0gVBw=r0Xk5rpPnhe7x6tRiw@mail.gmail.com> (raw)
In-Reply-To: <CAAhV-H5K9LG5P6WYJ+64-fi+s=TZbbJQG9E0vHJwOf9Pai5z4w@mail.gmail.com>
On Sat, Jun 25, 2022 at 5:04 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> Hi, Muchun,
>
> On Sat, Jun 25, 2022 at 4:50 PM Muchun Song <songmuchun@bytedance.com> wrote:
> >
> > On Sat, Jun 25, 2022 at 4:04 PM Feiyang Chen
> > <chris.chenfeiyang@gmail.com> wrote:
> > >
> > > The page-flags.h header relies on static keys since commit
> > > a6b40850c442bf ("mm: hugetlb: replace hugetlb_free_vmemmap_enabled
> > > with a static_key"), so make sure to include the header to avoid
> > > compilation errors.
> > >
> > > Fixes: a6b40850c442bf ("mm: hugetlb: replace hugetlb_free_vmemmap_enabled with a static_key")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn>
> > > ---
> > > include/linux/page-flags.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> > > index e66f7aa3191d..147b336c7a35 100644
> > > --- a/include/linux/page-flags.h
> > > +++ b/include/linux/page-flags.h
> > > @@ -11,6 +11,7 @@
> > > #include <linux/mmdebug.h>
> > > #ifndef __GENERATING_BOUNDS_H
> > > #include <linux/mm_types.h>
> > > +#include <linux/static_key.h>
> >
> > I did not include this. The change makes sense to me. But I am
> > curious what configs cause the compiling error. Would you mind
> > sharing the config with us?
> We found this problem when we add
> ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP to LoongArch. Since this isn't
Good news to me. I would love to hear more archs support for HVO (HugeTLB
Vmemmap Optimization).
> upstream yet, we cannot give such a config now (the default config of
> X86 and ARM64 is just OK).
All right. In this case, the "Cc: stable@vger.kernel.org" is unnecessary.
Thanks.
>
> Huacai
> >
> > Thanks.
> >
> > > #include <generated/bounds.h>
> > > #endif /* !__GENERATING_BOUNDS_H */
> > >
> > > --
> > > 2.27.0
> > >
> >
next prev parent reply other threads:[~2022-06-25 11:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 8:04 [PATCH] page-flags.h: Fix a missing header include of static_keys.h Feiyang Chen
2022-06-25 8:49 ` Muchun Song
2022-06-25 9:04 ` Huacai Chen
2022-06-25 11:16 ` Muchun Song [this message]
2022-06-25 14:00 ` [External] " Huacai Chen
2022-06-25 14:07 ` Greg KH
2022-06-25 14:17 ` Huacai Chen
2022-06-25 14:24 ` Greg KH
2022-06-25 14:26 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZfGtVq0VwMETGdzAXLkjes8W0gVBw=r0Xk5rpPnhe7x6tRiw@mail.gmail.com' \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=chris.chenfeiyang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).