loongarch.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Huacai Chen" <chenhuacai@kernel.org>,
	"Marc Zyngier" <maz@kernel.org>,
	"Tiezhu Yang" <yangtiezhu@loongson.cn>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
	loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v3 0/4] Give chance to build under !CONFIG_SMP for LoongArch
Date: Thu, 11 Apr 2024 08:06:43 +0200	[thread overview]
Message-ID: <b752273b-0e94-4325-9cf8-6f16a204818b@app.fastmail.com> (raw)
In-Reply-To: <CAAhV-H6bHudfUVE4SWY88mxmLhFok9DS8UyODSZEdUJ816V8Rg@mail.gmail.com>

On Thu, Apr 11, 2024, at 06:26, Huacai Chen wrote:
>
> I remember that you both suggested not introducing NOSMP support for a
> modern architecture which brings additional complexity. I wonder if
> you still have the same attitude now. I will merge this series only if
> you think it is worthy to introduce NOSMP now.

It's an interesting question, as we have recently discussed two
opposite ideas and may end up doing both (or possible neither)
in the future:

- On x86, there is no real reason to need non-SMP kernels as the
  memory savings are fairly small, and it tends to break because
  of lack of users testing it.

- On arm64, we have never supported non-SMP kernels, but I have
  looked at possibly adding this because there are still popular
  ARM based system-in-package products with less than 128MB of
  built-in RAM and only a single CPU. As these are moving from
  32-bit to 64-bit cores, it becomes more interesting to build
  a 64-bit UP kernel and save multiple megabytes.

I think loongarch64 is in the same place as arm64 and riscv64
(which does allow non-SMP builds) here, and there are good
reasons to allow it on all of them now, even if we previously
never had a need for it.

That said, both the 9% observed performance improvements that
Tiezhu Yang reported, and the memory savings that I saw are
probably higher than they should be, so we may also want to
investigate that further to see if we can improve the SMP
kernel to better support UP runs.

    Arnd

  reply	other threads:[~2024-04-11  6:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  1:05 [PATCH v3 0/4] Give chance to build under !CONFIG_SMP for LoongArch Tiezhu Yang
2024-04-11  1:05 ` [PATCH v3 1/4] LoongArch: Move CONFIG_HAVE_SETUP_PER_CPU_AREA related code to smp.c Tiezhu Yang
2024-04-12  4:12   ` Huacai Chen
2024-04-12  9:27     ` Tiezhu Yang
2024-04-13  7:20       ` Huacai Chen
2024-04-11  1:05 ` [PATCH v3 2/4] LoongArch: Refactor get_acpi_id_for_cpu() related code Tiezhu Yang
2024-04-12  4:17   ` Huacai Chen
2024-04-12  9:28     ` Tiezhu Yang
2024-04-11  1:05 ` [PATCH v3 3/4] LoongArch: Save and restore PERCPU_BASE_KS for ACPI S3 state Tiezhu Yang
2024-04-12  4:18   ` Huacai Chen
2024-04-12  9:30     ` Tiezhu Yang
2024-04-13  7:22       ` Huacai Chen
2024-04-11  1:05 ` [PATCH v3 4/4] LoongArch: Give chance to build under !CONFIG_SMP Tiezhu Yang
2024-04-11  4:26 ` [PATCH v3 0/4] Give chance to build under !CONFIG_SMP for LoongArch Huacai Chen
2024-04-11  6:06   ` Arnd Bergmann [this message]
2024-04-12  4:00     ` Huacai Chen
2024-04-18 17:44     ` Xi Ruoyao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b752273b-0e94-4325-9cf8-6f16a204818b@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=chenhuacai@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).