From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: Jan Kara <jack@suse.cz>, Matthew Bobrowski <repnop@google.com>
Subject: [LTP] [PATCH 0/3] fanotify{14,20}: cleanup
Date: Tue, 6 Sep 2022 11:26:12 +0200 [thread overview]
Message-ID: <20220906092615.15116-1-pvorel@suse.cz> (raw)
Hi,
just an example how to further cleanup fanotify tests by using test macros
from include/tst_test_macros.h. This can wait till Amir's FAN_MARK_IGNORE
patchset [1] is merged (unless there is going to be v2).
fanotify20 is an example what I'd address in the code, fanotify14 just
uses newly added TST_EXP_FD_ERRNO() (more cleanup here and actually in
other tests could be done).
I also admit code in include/tst_test_macros.h is a bit hard to read due
being macro. We should probably add some documentation to it.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/20220905154239.2652169-1-amir73il@gmail.com/
Petr Vorel (3):
tst_test_macros: Add TST_EXP_FD_ERRNO
fanotify20: Simplify code
fanotify14: Use TST_EXP_FD_ERRNO()
include/tst_test_macros.h | 10 ++
.../kernel/syscalls/fanotify/fanotify14.c | 118 +++++-------------
.../kernel/syscalls/fanotify/fanotify20.c | 81 +++---------
3 files changed, 62 insertions(+), 147 deletions(-)
--
2.37.3
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2022-09-06 9:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 9:26 Petr Vorel [this message]
2022-09-06 9:26 ` [LTP] [PATCH 1/3] tst_test_macros: Add TST_EXP_FD_ERRNO Petr Vorel
2022-09-06 9:26 ` [LTP] [PATCH 2/3] fanotify20: Simplify code Petr Vorel
2022-09-06 9:55 ` Amir Goldstein
2022-09-06 15:54 ` Petr Vorel
2022-09-06 16:14 ` Petr Vorel
2022-09-07 7:05 ` Matthew Bobrowski via ltp
2022-09-07 10:49 ` Petr Vorel
2022-09-06 9:26 ` [LTP] [PATCH 3/3] fanotify14: Use TST_EXP_FD_ERRNO() Petr Vorel
2022-09-06 10:13 ` Amir Goldstein
2022-09-06 15:56 ` Petr Vorel
2022-09-07 7:17 ` Matthew Bobrowski via ltp
2022-09-07 7:24 ` [LTP] [PATCH 0/3] fanotify{14,20}: cleanup Matthew Bobrowski via ltp
2022-09-07 11:05 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906092615.15116-1-pvorel@suse.cz \
--to=pvorel@suse.cz \
--cc=jack@suse.cz \
--cc=ltp@lists.linux.it \
--cc=repnop@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).