ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 5/5] dup05.c: use TST_EXP_FD() macro and make check fixes
Date: Mon, 29 May 2023 20:20:35 +0200	[thread overview]
Message-ID: <20230529182035.GB17253@pevik> (raw)
In-Reply-To: <20230427120800.27849-5-akumar@suse.de>

Hi Avinesh,

I slightly modified some of the commits and merged the patchset.
Thanks!

> + update copyright.
> + use SAFE_OPEN() and SAFE_CLOSE()


...
>  /*\
> - * [DESCRIPTION]
> + * [Description]
+1

>   *
>   * Basic test for dup(2) of a named pipe descriptor
>   */
> -#include <stdio.h>
> +
>  #include "tst_test.h"

> -char Fname[255];
> -int fd;
> +#define Fname "dupfile"
FYI I renamed to FNAME (don't hesitate to rename constants which aren't
lowercase or variables with very long name (expected_errno => exp_err - used
widely in LTP).

> +
> +static int fd;

>  static void run(void)
>  {
> -	TEST(dup(fd));
> -
> -	if (TST_RET == -1) {
> -		tst_res(TFAIL | TTERRNO, "dup failed");
> -	} else {
> -		tst_res(TPASS, "dup returned %ld",
> -			 TST_RET);
> -
> -		SAFE_CLOSE(TST_RET);
> -	}
> +	TST_EXP_FD(dup(fd), "dup(%d)", fd);
> +	SAFE_CLOSE(TST_RET);
>  }

> -void setup(void)
> +static void setup(void)
>  {
>  	fd = -1;
FYI I moved -1 to declaration:
static int fd = -1;

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-05-29 18:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 12:07 [LTP] [PATCH 1/5] dup01.c: use TST_EXP_FD macro and add inode check Avinesh Kumar
2023-04-27 12:07 ` [LTP] [PATCH 2/5] dup02.c: Simplify using TST_EXP macro and doc rewording Avinesh Kumar
2023-04-27 12:07 ` [LTP] [PATCH 3/5] dup03.c: use TST_EXP macro and make check fixes Avinesh Kumar
2023-04-27 12:07 ` [LTP] [PATCH 4/5] dup04.c: use TST_EXP_FD " Avinesh Kumar
2023-04-27 12:08 ` [LTP] [PATCH 5/5] dup05.c: use TST_EXP_FD() " Avinesh Kumar
2023-05-29 18:20   ` Petr Vorel [this message]
2023-05-02 11:18 ` [LTP] [PATCH 1/5] dup01.c: use TST_EXP_FD macro and add inode check Petr Vorel
2023-05-05  4:55   ` Avinesh Kumar
2023-05-29  5:42     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230529182035.GB17253@pevik \
    --to=pvorel@suse.cz \
    --cc=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).