From: zhaogongyi <zhaogongyi@huawei.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] lapi/syscalls: Add epoll_create for aarch64.in
Date: Thu, 28 Oct 2021 03:15:21 +0000 [thread overview]
Message-ID: <8a7e3282ca1441c0b44d7b994bf4edb9@huawei.com> (raw)
Hi,
I have resubmit a patch, please see: https://patchwork.ozlabs.org/project/ltp/patch/20211028031422.208689-1-zhaogongyi@huawei.com/
Thanks so much!
>
> On Wed, Oct 27, 2021 at 11:36 AM zhaogongyi <zhaogongyi@huawei.com>
> wrote:
> >
> > Hi,
> >
> >
> >
> > >
> > > On Wed, Oct 27, 2021 at 5:28 AM zhaogongyi
> <zhaogongyi@huawei.com>
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > >
> > > > > On Tue, Oct 26, 2021 at 9:49 AM Zhao Gongyi
> > > <zhaogongyi@huawei.com>
> > > > > wrote:
> > > > > >
> > > > > > Add epoll_create for aarch64.in and modify the value of
> > > > > > epoll_ctl for aarch64.in. Otherwise, the testcase
> > > > > > epoll_create01/epoll_create02 will fail.
> > > > > >
> > > > > > Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> > > > > > ---
> > > > > > include/lapi/syscalls/aarch64.in | 3 ++-
> > > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/include/lapi/syscalls/aarch64.in
> > > > > > b/include/lapi/syscalls/aarch64.in
> > > > > > index a47185954..e9023a1d0 100644
> > > > > > --- a/include/lapi/syscalls/aarch64.in
> > > > > > +++ b/include/lapi/syscalls/aarch64.in
> > > > > > @@ -19,7 +19,6 @@ getcwd 17
> > > > > > lookup_dcookie 18
> > > > > > eventfd2 19
> > > > > > epoll_create1 20
> > > > > > -epoll_ctl 21
> > > > > > epoll_pwait 22
> > > > > > dup 23
> > > > > > dup3 24
> > > > > > @@ -243,6 +242,8 @@ rt_tgsigqueueinfo 240
> perf_event_open
> > > 241
> > > > > > accept4 242
> > > > > > recvmmsg 243
> > > > > > +epoll_create 250
> > > > > > +epoll_ctl 251
> > > > >
> > > > > These values are for 32 bit only syscalls. Won't this break 64 bit?
> > > >
> > > > Yes, these values are for 32 bit only syscalls, the syscall
> > > > epoll_create is
> > > not support for 64bit arm64.
> > >
> > > Right, adding epoll_create is OK, but changing epoll_ctl would break
> > > 64bit if there were any users of __NR_epoll_ctl.
> >
> > If we do not consider the running of 32bit program on arm64, we need
> to remove __NR_epoll_ctl.
> >
> > And the testcase using __NR_epoll_ctl will fail, is it a problem to be
> resolved?
>
> There are no testcases currently using __NR_epoll_ctl, but to avoid this
> potential issues in future, we can remove it. Existing testcases use libc
> epoll_ctl().
>
> >
> > >
> > > >
> > > > Reference to man 2 epoll_create, we can see that
> > > epoll_create/epoll_create1 are supported If only we include the
> > > header file sys/epoll.h.
> > > >
> > > > Is it better that we call epoll_create replace to syscall
> > > __NR_epoll_create since some plateform not support it?
> > >
> > > I think so. We already use epoll_create() in other tests, so this
> > > looks like simplest solution for all arches.
> > >
> > > >
> > > >
> > > > Thanks for you review!
> > > >
> > > > >
> > > > > > wait4 260
> > > > > > prlimit64 261
> > > > > > fanotify_init 262
> > > > > > --
> > > > > > 2.17.1
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Mailing list info: https://lists.linux.it/listinfo/ltp
> > > > > >
> > > >
> >
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2021-10-28 3:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 3:15 zhaogongyi [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-27 9:55 [LTP] [PATCH] lapi/syscalls: Add epoll_create for aarch64.in zhaogongyi
2021-10-27 9:36 zhaogongyi
2021-10-27 9:44 ` Jan Stancek
2021-10-27 3:28 zhaogongyi
2021-10-27 8:35 ` Jan Stancek
2021-10-26 7:50 Zhao Gongyi
2021-10-26 12:30 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a7e3282ca1441c0b44d7b994bf4edb9@huawei.com \
--to=zhaogongyi@huawei.com \
--cc=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).