From: Li Wang <liwan@redhat.com>
To: Avinesh Kumar <akumar@suse.de>, Petr Vorel <pvorel@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] statvfs01: Convert to new LTP API
Date: Thu, 1 Dec 2022 17:17:08 +0800 [thread overview]
Message-ID: <CAEemH2eDBmac9hSZ+n_hQhLjaHOtxqSAj+QfJ_Sc_+4jd4hDww@mail.gmail.com> (raw)
In-Reply-To: <1774275.JVTEKzzMJm@localhost>
[-- Attachment #1.1: Type: text/plain, Size: 1471 bytes --]
Avinesh Kumar <akumar@suse.de> wrote:
> How about
> > 1) don't skip exfat and vfat but just skip creating file with valid
> name? or
> >
> > 2) Add #define NLS_MAX_CHARSET_SIZE 6 and for vfat and exfat calculate
> > length as: buf.f_namemax / NLS_MAX_CHARSET_SIZE - 1 ?
>
> Thank you for the review and research on vfat, exfat scenarios.
> I have adopted the option 1 for now and sent a v3 of this patch.
>
I thought option_1 meant to skip creating a valide-file when
detecting on "vfat,exfat" FS, but not skip for others.
Or probably I misunderstood Petr's words.
Anyway, don't hurry to send V3 until we get an agreement :).
--- a/testcases/kernel/syscalls/statvfs/statvfs01.c
+++ b/testcases/kernel/syscalls/statvfs/statvfs01.c
@@ -30,7 +30,10 @@ static void run(void)
memset(valid_fname, 'a', buf.f_namemax - 1);
memset(invalid_fname, 'b', buf.f_namemax + 1);
- TST_EXP_FD(creat(valid_fname, 0444));
+ long fs_type = tst_fs_type(TEST_PATH);
+ if (fs_type != TST_VFAT_MAGIC && fs_type != TST_EXFAT_MAGIC)
+ TST_EXP_FD(creat(valid_fname, 0444));
+
TST_EXP_FAIL(creat(invalid_fname, 0444), ENAMETOOLONG);
}
@@ -46,9 +49,4 @@ static struct tst_test test = {
.mount_device = 1,
.mntpoint = MNT_POINT,
.all_filesystems = 1,
- .skip_filesystems = (const char *const[]) {
- "vfat",
- "exfat",
- NULL
- }
};
--
Regards,
Li Wang
[-- Attachment #1.2: Type: text/html, Size: 2843 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-12-01 9:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 11:42 [LTP] [PATCH] statvfs01: Convert to new LTP API Avinesh Kumar
2022-11-25 2:18 ` Li Wang
2022-11-29 10:58 ` Richard Palethorpe
2022-11-30 7:05 ` [LTP] [PATCH v2] " Avinesh Kumar
2022-11-30 8:52 ` Petr Vorel
2022-11-30 9:50 ` Petr Vorel
2022-12-01 5:16 ` Li Wang
2022-12-01 9:34 ` Richard Palethorpe
2022-12-02 9:20 ` Petr Vorel
2022-12-01 8:51 ` Avinesh Kumar
2022-12-01 9:17 ` Li Wang [this message]
2022-12-01 10:45 ` Petr Vorel
2022-12-01 11:04 ` Avinesh Kumar
2022-11-30 7:20 ` [LTP] [PATCH] " Li Wang
2022-12-01 6:00 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEemH2eDBmac9hSZ+n_hQhLjaHOtxqSAj+QfJ_Sc_+4jd4hDww@mail.gmail.com \
--to=liwan@redhat.com \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).