From: Li Wang <liwang@redhat.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] cleanup: changing FILE_PRINTF to SAFE_FILE_PRINTF
Date: Thu, 1 Jun 2023 14:44:24 +0800 [thread overview]
Message-ID: <CAEemH2fE2c=wdrTWKMUNMqo6yscOpMSMxkaruDQNBFPMyHcBjQ@mail.gmail.com> (raw)
In-Reply-To: <20230526142547.GA812267@pevik>
Hi Petr,
On Fri, May 26, 2023 at 10:25 PM Petr Vorel <pvorel@suse.cz> wrote:
> > --- a/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c
> > +++ b/testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c
> > @@ -78,10 +78,10 @@ static void check_set_turbo(char *file, char *off)
>
> > static void cleanup(void)
> > {
> > - FILE_PRINTF(cdrv[id].file, "%d", boost_value);
> > + SAFE_FILE_PRINTF(cleanup, cdrv[id].file, "%d", boost_value);
>
> testcases/kernel/device-drivers/cpufreq/cpufreq_boost.c uses old API,
> IMHO not affected by 6440c5d0d15. Therefore we should postpone this till
> it's
> converted to the new API.
>
That's right. I revert the change and pushed it, thanks!!
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-06-01 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 8:09 [LTP] [PATCH 1/2] FILE_PRINTF|SCANF: changing TWARN to TINFO Li Wang
2023-05-25 8:09 ` [LTP] [PATCH 2/2] cleanup: changing FILE_PRINTF to SAFE_FILE_PRINTF Li Wang
2023-05-26 14:25 ` Petr Vorel
2023-06-01 6:44 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEemH2fE2c=wdrTWKMUNMqo6yscOpMSMxkaruDQNBFPMyHcBjQ@mail.gmail.com' \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).