From: Li Wang <liwang@redhat.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>,
Joerg Vehlow <joerg.vehlow@aox-tech.de>,
LTP List <ltp@lists.linux.it>,
automated-testing@lists.yoctoproject.org
Subject: Re: [LTP] [PATCH 2/6] API: tst_device: Track minimal size per filesystem
Date: Tue, 30 Aug 2022 14:11:25 +0800 [thread overview]
Message-ID: <CAEemH2fkB5yDH-=RggA2XZC7ALHo-yOJYkd6=dTfHRfu6sd-Wg@mail.gmail.com> (raw)
In-Reply-To: <YwybzIVhMaCqYR/S@yuki>
[-- Attachment #1.1: Type: text/plain, Size: 754 bytes --]
Cyril Hrubis <chrubis@suse.cz> wrote:
>
> > + return MAX(DEV_SIZE_MB_BTRFS, DEV_SIZE_MB_DEFAULT);
>
> I do not think that we should harcode this here. I would be for a more
> dynamic approach, i.e. add a function into the tst_supported_fs_types.c
> that loops over supported filesystems and chooses max over the minimal
> values for all supported filesystems. That way if we run on embedded
> targets the device size will be 16MB as long as btrfs-progs is not
> installed. Also that way we can easily define minimal size for xfs 300MB
> and things will work for embedded as long as xfs-progs are not
> installed.
>
+1 this is a quite good suggestion that solved what we were concerned about
different XFS code paths.
--
Regards,
Li Wang
[-- Attachment #1.2: Type: text/html, Size: 1301 bytes --]
[-- Attachment #2: Type: text/plain, Size: 60 bytes --]
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-08-30 6:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-27 0:28 [LTP] [PATCH 0/6] Track minimal size per filesystem Petr Vorel
2022-08-27 0:28 ` [LTP] [PATCH 1/6] tst_fs_type: Add nsfs, vfat, squashfs to tst_fs_type_name() Petr Vorel
2022-08-29 10:44 ` Cyril Hrubis
2022-08-29 15:46 ` Bird, Tim
2022-08-29 16:14 ` Petr Vorel
2022-08-29 16:35 ` Bird, Tim
2022-08-29 16:49 ` Petr Vorel
2022-08-30 5:59 ` Li Wang
2022-08-27 0:28 ` [LTP] [PATCH 2/6] API: tst_device: Track minimal size per filesystem Petr Vorel
2022-08-29 10:58 ` Cyril Hrubis
2022-08-29 11:29 ` Petr Vorel
2022-08-29 12:24 ` [LTP] [Automated-testing] " Cyril Hrubis
2022-08-30 6:11 ` Li Wang [this message]
2022-08-27 0:28 ` [LTP] [PATCH 3/6] tst_test: Use 16 MB also for tmpfs Petr Vorel
2022-08-29 11:00 ` Cyril Hrubis
2022-08-30 6:12 ` Li Wang
2022-08-27 0:28 ` [LTP] [PATCH 4/6] tst_device: Use getopts Petr Vorel
2022-08-29 11:03 ` [LTP] [Automated-testing] " Cyril Hrubis
2022-08-29 11:42 ` Petr Vorel
2022-08-30 6:14 ` [LTP] " Li Wang
2022-08-27 0:28 ` [LTP] [PATCH 5/6] tst_device: Add support -f filesystem Petr Vorel
2022-08-29 11:04 ` Cyril Hrubis
2022-08-30 6:14 ` Li Wang
2022-08-27 0:28 ` [LTP] [PATCH 6/6] tst_test.sh: Pass used filesystem to tst_device Petr Vorel
2022-08-29 11:05 ` Cyril Hrubis
2022-08-30 6:16 ` Li Wang
2022-08-29 10:43 ` [LTP] [Automated-testing] [PATCH 0/6] Track minimal size per filesystem Cyril Hrubis
2022-08-29 11:39 ` Petr Vorel
2022-08-30 5:52 ` Li Wang
2022-08-30 8:18 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEemH2fkB5yDH-=RggA2XZC7ALHo-yOJYkd6=dTfHRfu6sd-Wg@mail.gmail.com' \
--to=liwang@redhat.com \
--cc=automated-testing@lists.yoctoproject.org \
--cc=chrubis@suse.cz \
--cc=joerg.vehlow@aox-tech.de \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).