ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Li Wang <liwang@redhat.com>
To: Martin Doucha <mdoucha@suse.cz>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2] Terminate leftover subprocesses when main test process crashes
Date: Sat, 12 Feb 2022 11:03:51 +0800	[thread overview]
Message-ID: <CAEemH2fqy3_t=-dbqE9Bx3VH6sZbNvM_bMon4zMukOh+rmw42Q@mail.gmail.com> (raw)
In-Reply-To: <2e218131-be2b-d6c8-51f7-f12b9091e859@suse.cz>


[-- Attachment #1.1: Type: text/plain, Size: 625 bytes --]

On Fri, Feb 11, 2022 at 9:30 PM Martin Doucha <mdoucha@suse.cz> wrote:

> On 11. 02. 22 13:55, Cyril Hrubis wrote:
> > Hi!
> >> --- a/lib/tst_test.c
> >> +++ b/lib/tst_test.c
> >> @@ -1495,6 +1495,9 @@ static int fork_testrun(void)
> >>              return TFAIL;
> >>      }
> >>
> >> +    if (tst_test->forks_child)
> >> +            kill(-test_pid, SIGKILL);
> >> +
> >
> > Maybe we can even print a message here if the kill() returns with 0,
> > which would mean that there were any leftover child processes killed.
>
> Feel free to add a message during merge.
>

I added that and applied. Thanks~


-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 1313 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-02-12  3:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 11:44 [LTP] [PATCH v2] Terminate leftover subprocesses when main test process crashes Martin Doucha
2022-02-11 12:55 ` Cyril Hrubis
2022-02-11 13:29   ` Martin Doucha
2022-02-12  3:03     ` Li Wang [this message]
2022-02-18 12:30       ` [LTP] 72b1728674 causing regressions [ [PATCH v2] Terminate leftover subprocesses when main test process crashes] Petr Vorel
2022-02-18 12:42         ` Cyril Hrubis
2022-02-18 14:42           ` Petr Vorel
2022-02-18 14:48             ` Cyril Hrubis
2022-02-18 15:32               ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEemH2fqy3_t=-dbqE9Bx3VH6sZbNvM_bMon4zMukOh+rmw42Q@mail.gmail.com' \
    --to=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).