From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] setfsuid02: using -1 as invalid fsuid for setfsuid()
Date: Mon, 31 Oct 2022 12:37:30 +0100 [thread overview]
Message-ID: <Y1+zeo9kmWOl2yE3@pevik> (raw)
In-Reply-To: <20221027140954.4094-1-akumar@suse.de>
Hi Avinesh,
> a uid which does not have an entry in the /etc/passwd
> file is not really an invalid fsuid for setfsuid(), so changing
> the test to use -1 as an invalid fsuid.
> And second setfsuid(-1) call is to verify that preceding call has
> actually failed and there is no change in the fsuid.
Here was supposed to be
Fixes: 85f0b8478 ("setfsuid02: Rewrite using new LTP API")
as the problem was introduced in your rewrite, right?
> diff --git a/testcases/kernel/syscalls/setfsuid/setfsuid02.c b/testcases/kernel/syscalls/setfsuid/setfsuid02.c
> index 850f17834..f5aa1c004 100644
> --- a/testcases/kernel/syscalls/setfsuid/setfsuid02.c
> +++ b/testcases/kernel/syscalls/setfsuid/setfsuid02.c
> @@ -21,9 +21,7 @@ static void run(void)
> uid_t invalid_uid, current_uid;
> current_uid = geteuid();
> - invalid_uid = 1;
> - while (getpwuid(invalid_uid))
> - invalid_uid++;
> + invalid_uid = -1;
IMHO it should be casted
invalid_uid = (uid_t)-1;
as the code in shadow-utils:
https://github.com/shadow-maint/shadow/blob/eaebea55a495a56317ed85e959b3599f73c6bdf2/src/newusers.c#L342-L345
This does not work on 16-bit version, because uid_t is unsigned int,
-1 overflows the allowed value when we do check:
UID16_CHECK(invalid_uid, setfsuid);
setfsuid02.c:26: TBROK: uid -1 of invalid_uid is too large for testing 16-bit version of setfsuid()
It also does not make sense to check invalid_uid, it should have been
current_uid in 85f0b8478 (my bad not catching this):
UID16_CHECK(current_uid, setfsuid);
Please, always try to test 16-bit variant (most of us does not bother to test
32-bit compatibility, but at least to see TCONF is worth).
If you agree, I merge it with changes below.
Kind regards,
Petr
diff --git testcases/kernel/syscalls/setfsuid/setfsuid02.c testcases/kernel/syscalls/setfsuid/setfsuid02.c
index f5aa1c004..92e1979fa 100644
--- testcases/kernel/syscalls/setfsuid/setfsuid02.c
+++ testcases/kernel/syscalls/setfsuid/setfsuid02.c
@@ -21,9 +21,9 @@ static void run(void)
uid_t invalid_uid, current_uid;
current_uid = geteuid();
- invalid_uid = -1;
+ invalid_uid = (uid_t)-1;
- UID16_CHECK(invalid_uid, setfsuid);
+ UID16_CHECK(current_uid, setfsuid);
TST_EXP_VAL_SILENT(SETFSUID(invalid_uid), current_uid);
TST_EXP_VAL(SETFSUID(invalid_uid), current_uid,
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-10-31 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 14:09 [LTP] [PATCH] setfsuid02: using -1 as invalid fsuid for setfsuid() Avinesh Kumar
2022-10-31 11:37 ` Petr Vorel [this message]
2022-10-31 13:36 ` Martin Doucha
2022-10-31 13:50 ` Petr Vorel
2022-10-31 14:00 ` Martin Doucha
2022-10-31 14:56 ` Petr Vorel
2022-10-31 17:23 ` Martin Doucha
2022-10-31 21:39 ` Petr Vorel
2022-11-02 7:40 ` Avinesh Kumar
2022-10-31 13:01 ` Richard Palethorpe
2022-10-31 21:40 ` Petr Vorel
2022-11-01 9:03 ` Richard Palethorpe
2022-11-02 7:52 ` Avinesh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1+zeo9kmWOl2yE3@pevik \
--to=pvorel@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).