From: Petr Vorel <pvorel@suse.cz>
To: zenghongling <zenghongling@kylinos.cn>, ltp@lists.linux.it
Cc: Richard Palethorpe <rpalethorpe@suse.com>
Subject: Re: [LTP] [PATCH] mkfs: relax size check
Date: Wed, 30 Nov 2022 09:06:39 +0100 [thread overview]
Message-ID: <Y4cPD+1DJhMwGPpj@pevik> (raw)
In-Reply-To: <Y4Xd4jd/X5zsmoqH@pevik>
Hi all,
> Hi zenghongling,
> > Number of total data blocks in filesystem reported by statfs
> > may be less than current formula of 90%. For example ext4 will
> > subtract "s_first_data_block plus internal journal blocks".
> > With recent change to e2fsprogs, overhead calculated in user-space increased
> Do you know in which version it got changed?
For a record, zenghongling send html mail
https://lore.kernel.org/ltp/2oc1dehrobv-2oc577y0tt8@nsmail7.0.0--kylin--1/T/#u
thus repeat it here: the affected commit is here:
https://github.com/tytso/e2fsprogs/commit/59037c5357d39c6d0f14a0aff70e67dc13eafc84
which is from v1.46.0.
I'm testing it on openSUSE with 1.46.5 and it does not have problem.
Maybe there is some problem on the system you test and lower the barrier you
just hide it. Maybe others see it differently.
> Maybe it'd be worth to mention that to ext4 maintainers,
> just to be sure it's not a regression.
> > slightly and LTP test started failing: tytso/e2fsprogs
> A bit cryptic description :(. You mean probably https://github.com/tytso/e2fsprogs
> which is also on
> https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/
@zenghongling basic mailing list rules
1) sent text/plain (not text/html), otherwise mail is not readable
https://lore.kernel.org/ltp/2oc1dehrobv-2oc577y0tt8@nsmail7.0.0--kylin--1/T/#u
and not even in patchwork:
https://patchwork.ozlabs.org/project/ltp/patch/1669691831-23456-1-git-send-email-zenghongling@kylinos.cn/
Compare with my mail:
https://lore.kernel.org/ltp/Y4Xd4jd%2FX5zsmoqH@pevik/T/#m76d4ae3f396a6ae63382cb569c33d8c746ce0974
More instructions are:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
2) reply to mail thread so that mail is connected to the thread
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#explicit-in-reply-to-headers
Actually most of the reading for kernel applies to LTP as well
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-30 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 3:17 [LTP] [PATCH] mkfs: relax size check zenghongling
2022-11-29 10:24 ` Petr Vorel
2022-11-30 8:06 ` Petr Vorel [this message]
2022-12-12 15:03 ` Richard Palethorpe
-- strict thread matches above, loose matches on Subject: below --
2021-04-23 11:16 Jan Stancek
2021-04-23 15:06 ` Petr Vorel
2021-04-23 15:28 ` Petr Vorel
2021-04-26 13:11 ` Li Wang
2021-04-26 19:28 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4cPD+1DJhMwGPpj@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
--cc=zenghongling@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).