From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] netns_netlink: Rewrite into new API
Date: Mon, 22 Feb 2021 09:28:11 +0100 [thread overview]
Message-ID: <YDNrG9A8Dlm2k8uh@pevik> (raw)
In-Reply-To: <878s7k59tk.fsf@suse.de>
Hi Richie,
> Hello,
> Petr Vorel <pvorel@suse.cz> writes:
> > From: Richard Palethorpe <rpalethorpe@suse.com>
> I don't remember this :-)
I'm sorry, that should be me :). I normally does not have problems with git,
but this time I messed things up with rebasing.
> > This also require to rewrite netns_helper.h.
> > New test still uses legacy libclone.h.
> > ...
> > pclose(ipf);
> > @@ -67,14 +53,14 @@ static void check_netns(void)
> > int pid, status;
> > /* Checking if the kernel supports unshare with netns capabilities. */
> > if (CLONE_NEWNS == -1)
> > - tst_brkm(TCONF | TERRNO, NULL, "CLONE_NEWNS (%d) not supported",
> > + tst_brk(TCONF | TERRNO, "CLONE_NEWNS (%d) not supported",
> > CLONE_NEWNS);
> > pid = do_clone_unshare_test(T_UNSHARE, CLONE_NEWNET | CLONE_NEWNS,
> > dummy, NULL);
> I guess you are considering replacing this with something that uses
> SAFE_CLONE?
> This should be quite easy as this function is not cloning with CLONE_VM
> or anything special. It is just fork() with CLONE_NEWNET | CLONE_NEWNS,
> so we probably don't need most of the wierdness in libclone.
+1, I'd also like to get rid of libclone.
Kind regards,
Petr
prev parent reply other threads:[~2021-02-22 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 14:47 [LTP] [PATCH 0/2] netns_netlink: Rewrite into new API Petr Vorel
2021-02-19 14:47 ` [LTP] [PATCH 1/2] libclone: Move test.h include to C file Petr Vorel
2021-05-11 8:20 ` Cyril Hrubis
2021-05-11 13:54 ` Petr Vorel
2021-02-19 14:47 ` [LTP] [PATCH 2/2] netns_netlink: Rewrite into new API Petr Vorel
2021-02-19 15:57 ` Richard Palethorpe
2021-02-22 8:28 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDNrG9A8Dlm2k8uh@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).