ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls: Use anonymous .resource_files for docparse
Date: Thu, 11 Mar 2021 11:33:05 +0100	[thread overview]
Message-ID: <YEnx4V3Il/VrThv/@pevik> (raw)
In-Reply-To: <YEkAH6xJlSK99bp+@pevik>

Hi,

...
> > Hi Petr,

> > I can use file name directly in v2 patch.
> OK. I'd like to know the others opinion (precedent).

> > Do you agree to use anonymous .resource_files for now? or is it better to
> > keep it?
> I guess yes, we've already started to use it.

> > > Not sure how far we should go with moving everything into inline anonymous
> > > definitions (it'd be nice if docparse was able to just expand macros, but that
> > > would be way too slow).

> > I agree that expanding macros or structs is the nicer way but

> > we need to do some investigation about it.
> gcc -E foo.c would do expansion for us. But not sure if it's worth of runtime.
> Because problem of missing definitions will be on other places and we don't want
> to get rid of definitions. e.g. I planned to add some tag definitions (for
> "linux-git", ...) as Martin Doucha suggested, but this would not work until
> we expand macros.

I was looking into the output of gcc -E but it brings other problems.
Wouldn't be better instead of patching like this to just replace docparse.c with
library support to test itself print it's description in json format
(e.g. --print-json opt)? I was thinking to use the same for shell tests docparse
(which aren't covered at all yet).

The downside would be that generation would be much slower and require native
build.

> Kind regards,
> Petr

> > Best Regards,

> > Xiao Yang

  reply	other threads:[~2021-03-11 10:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  2:32 [LTP] [PATCH] syscalls: Use anonymous .resource_files for docparse Xiao Yang
2021-03-10 10:32 ` Petr Vorel
2021-03-10 14:54   ` Xiao Yang
2021-03-10 17:21     ` Petr Vorel
2021-03-11 10:33       ` Petr Vorel [this message]
2021-03-11 10:42         ` Cyril Hrubis
2021-03-12 11:05           ` Petr Vorel
2021-03-12 13:12             ` Cyril Hrubis
2021-03-12 13:24               ` Petr Vorel
2022-02-25 12:37                 ` Petr Vorel
2022-08-23 14:24                   ` Cyril Hrubis
2022-08-23 15:47                     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEnx4V3Il/VrThv/@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).