From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F966C433FE for ; Tue, 26 Oct 2021 14:23:17 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9EC560FD7 for ; Tue, 26 Oct 2021 14:23:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C9EC560FD7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4F2BB3C67F7 for ; Tue, 26 Oct 2021 16:23:15 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0F6273C67DE for ; Tue, 26 Oct 2021 16:23:05 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 4F0061A0111F for ; Tue, 26 Oct 2021 16:23:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9C6B7218B8; Tue, 26 Oct 2021 14:23:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635258184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zxjmItgm4YVzJ/9Gx+xyR/QEFsE+UuW7/E9PYCllszI=; b=Z8mLkg2z/JR7Xl1yqGhEbAkuE7CuFAfsznYV914rp7jcZYZ/fB45R99IEl8skHks/OoWVG L0Ae1TKDHfyRmRsyCnLZ2R3ak50toJGZxBNkSakuxOMYOyHUmOthaKA34uH+8GO8Ea7+r7 UPWtVo0j9vWd+4lxg7RyQuMtNl2jJWc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635258184; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zxjmItgm4YVzJ/9Gx+xyR/QEFsE+UuW7/E9PYCllszI=; b=P7m5SlsTmq3dVN2uY2i1IxhvovzPJYWj/iVtU7guARIPxAMDAW42g3s/z921drgPLR9jBb 1w1Sk4DymBpdZACA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 82E9D13B06; Tue, 26 Oct 2021 14:23:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id oYJDH0gPeGHIEwAAMHmgww (envelope-from ); Tue, 26 Oct 2021 14:23:04 +0000 Date: Tue, 26 Oct 2021 16:23:54 +0200 From: Cyril Hrubis To: Yang Xu Message-ID: References: <1634562888-5987-1-git-send-email-xuyang2018.jy@fujitsu.com> <1634562888-5987-3-git-send-email-xuyang2018.jy@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1634562888-5987-3-git-send-email-xuyang2018.jy@fujitsu.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1 08/11] syscalls/quotaclt02, 5: Add quotactl_fd test variant X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > @@ -166,9 +174,11 @@ static struct tst_test test = { > .tcnt = ARRAY_SIZE(tcases), > .mount_device = 1, > .dev_fs_type = "xfs", > - .mntpoint = mntpoint, > + .mntpoint = MNTPOINT, > .mnt_data = "usrquota,grpquota", > .setup = setup, > + .cleanup = cleanup, > + .test_variants = 2, It may be a slightly cleaner to #define QUOTACTL_VARIANTS 2 in the quotactl_var.h and use it here. > }; > #else > TST_TEST_TCONF("System doesn't have "); > diff --git a/testcases/kernel/syscalls/quotactl/quotactl02.h b/testcases/kernel/syscalls/quotactl/quotactl02.h > index 37f3d7eb7..5b7c5ab32 100644 > --- a/testcases/kernel/syscalls/quotactl/quotactl02.h > +++ b/testcases/kernel/syscalls/quotactl/quotactl02.h > @@ -14,18 +14,20 @@ > #include > #include "tst_test.h" > #include "lapi/quotactl.h" > +#include "quotactl_var.h" Here as well, no need to include the "lapi/quotactl.h" anymore. Other than that this patch looks good. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp