ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 11/11] syscalls/quotactl09: Test error when quota info hidden in filesystem
Date: Tue, 26 Oct 2021 16:41:36 +0200	[thread overview]
Message-ID: <YXgToPshvc9WiQ9q@yuki> (raw)
In-Reply-To: <1634562996-6045-1-git-send-email-xuyang2018.jy@fujitsu.com>

Hi!
Generally looks good, same minor comments as for the rest of the
patchset apply here as well:

- for the description comment
- no need to include "lapi/quotactl.h"
- there are some trailing whitespaces (have you run make check before submitting?)
- does geteuid() in setup return anything else than 0?

Also I wonder if we should include the fmtv0 in the variant list, but as
far as I can tell it only matters for the tests that attempt to set the
limits, right?

I guess that we can define the test variants as:

static struct quotactl_variant {
	int use_fd;
	int32_t fmt_id;
	const char *fmt_name;
} variants[] = {
	{.use_fd = 0, .fmt_id = QFMT_VFS_V1, .fmt_name = "fmtv1"},
	{.use_fd = 1, .fmt_id = QFMT_VFS_V1, .fmt_name = "fmtv1"},
	{.use_fd = 0, .fmt_id = QFMT_VFS_V0, .fmt_name = "fmtv0"},
	{.use_fd = 1, .fmt_id = QFMT_VFS_V0, .fmt_name = "fmtv0"},
};

And then set .variants = 2 for all the tests that does not touch the
limits and for these tests that manipulate the limits set .variants = 4

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-10-26 14:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 13:16 [LTP] [PATCH v1 11/11] syscalls/quotactl09: Test error when quota info hidden in filesystem Yang Xu
2021-10-26 14:41 ` Cyril Hrubis [this message]
2021-10-27  3:26   ` xuyang2018.jy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXgToPshvc9WiQ9q@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).