From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] test_macros: TST_EXP_EXPR() add auto stringification
Date: Fri, 18 Feb 2022 10:54:34 +0100 [thread overview]
Message-ID: <Yg9s2lzZmavrQCuf@yuki> (raw)
In-Reply-To: <Yg56J2hVIMMO3cvX@pevik>
Hi!
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Good idea.
It occured to me that this is probably not the best result though, since
in the case of the failure it does not print the expected and actual
value. So maybe it would be better to add TST_EXP_EQ() macro instead. I
will send a patch later on.
> BTW I'm thinking to add some comments to "top level" macros.
> because it's getting hard to read these macros.
Well yes, it's getting a bit hard to read indeed.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-18 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:27 [LTP] [PATCH] test_macros: TST_EXP_EXPR() add auto stringification Cyril Hrubis
2022-02-17 16:39 ` Petr Vorel
2022-02-18 9:54 ` Cyril Hrubis [this message]
2022-02-18 10:31 ` Petr Vorel
2022-02-18 10:35 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg9s2lzZmavrQCuf@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).