From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] lib: Rename array used for .all_filesystems flag
Date: Tue, 8 Feb 2022 18:23:56 +0100 [thread overview]
Message-ID: <YgKnLPyjwf3netv8@pevik> (raw)
In-Reply-To: <YgKHi9eYqd35Li71@yuki>
> Hi!
> > > I guess that fs_type_whitelist[] may be confusing but all_filesystems[]
> > > is IMHO not that much better since we use that a as base for the
> > > all_filesystem before we filter out these that are not supported. Maybe
> > > we should call it try_filesystems[] instead?
> > Well, how I understand it the main feature is to be for .all_filesystems. And
> > items of this array can be whitelisted. Thus try_filesystems does not evoke much
> > to me that it's for all_filesystems.
> > I considered to have array all_filesystems[] and .fs_type_whitelist pointer to
> > that array, but having pointer just to document things is bad idea.
> The reason why I do not think it's reasonable to name the array
> all_filesystems is that setting the .all_filesystems flag does not mean
> that the test would be run over all these filesytems. We just silently
> skip these that are not supported...
Understand. Also try_filesystems is certainly better than fs_type_whitelist.
How about default_all_filesystems or just default_filesystems?
Regardless we rename it or not, at least the comment I put in the patchset would
improve things (although you may phrase it better).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-02-08 17:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 14:11 [LTP] [PATCH 1/1] lib: Rename array used for .all_filesystems flag Petr Vorel
2022-01-26 14:44 ` Petr Vorel
2022-02-08 13:16 ` Cyril Hrubis
2022-02-08 15:00 ` Petr Vorel
2022-02-08 15:08 ` Cyril Hrubis
2022-02-08 17:23 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgKnLPyjwf3netv8@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).