ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it, Martin Doucha <martin.doucha@suse.com>,
	Cyril Hrubis <chrubis@suse.cz>, Li Wang <liwang@redhat.com>
Subject: Re: [LTP] [PATCH 1/2] tst_test.sh: Cleanup getopts usage
Date: Fri, 22 Apr 2022 11:23:06 +0200	[thread overview]
Message-ID: <YmJz+odTX8Q8XV56@pevik> (raw)
In-Reply-To: <Ykd9CAXfi9FZ+iHB@pevik>

Hi all,

Martin spotted another error in zram01: setup() function in zram01.sh was not
called due being overwritten in zram_lib.sh. Replaced with conditional
expansion.

In case anybody wants to test this latest version is branch
tst_test.sh/cleanup-getopts.fixes in my fork:
https://github.com/pevik/ltp/commits/tst_test.sh/cleanup-getopts.fixes

Kind regards,
Petr

diff --git testcases/kernel/device-drivers/zram/zram_lib.sh testcases/kernel/device-drivers/zram/zram_lib.sh
index f2280334e8..6ce2ff1d4f 100755
--- testcases/kernel/device-drivers/zram/zram_lib.sh
+++ testcases/kernel/device-drivers/zram/zram_lib.sh
@@ -12,7 +12,7 @@ sys_control=-1
 
 TST_NEEDS_TMPDIR=1
 TST_NEEDS_ROOT=1
-TST_SETUP="zram_load"
+TST_SETUP="${TST_SETUP:-zram_load}"
 TST_CLEANUP="zram_cleanup"
 TST_NEEDS_DRIVERS="zram"
 

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-04-22  9:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-01 21:59 [LTP] [PATCH 0/2] shell: Cleanup getopts usage Petr Vorel
2022-04-01 21:59 ` [LTP] [PATCH 1/2] tst_test.sh: " Petr Vorel
2022-04-01 22:11   ` Petr Vorel
2022-04-01 22:30   ` Petr Vorel
2022-04-22  9:23     ` Petr Vorel [this message]
2022-04-01 21:59 ` [LTP] [PATCH 2/2] doc: Update shell API examples Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmJz+odTX8Q8XV56@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=martin.doucha@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).