Re: [LTP] [PATCH 1/5] syscalls/inotify12: Introduce test for inotify mask flags

From: Petr Vorel <pvorel@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Matthew Bobrowski <repnop@google.com>, Jan Kara <jack@suse.cz>,
	LTP List <ltp@lists.linux.it>,
	Richard Palethorpe <rpalethorpe@suse.com>
Subject: Re: [LTP] [PATCH 1/5] syscalls/inotify12: Introduce test for inotify mask flags
Date: Mon, 13 Jun 2022 18:05:46 +0200	[thread overview]
Message-ID: <YqdgWvHoiqeANzCi@pevik> (raw)
In-Reply-To: <CAOQ4uxh6aJq+uMsFOBBeG+S3OTGABP2qmb7oDXOATa35A83H3g@mail.gmail.com>

> On Mon, Jun 13, 2022 at 6:23 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Amir,

> > > > diff --git a/testcases/kernel/syscalls/inotify/inotify12.c b/testcases/kernel/syscalls/inotify/inotify12.c
> > ...
> > > > +static struct tst_test test = {
> > > > +       .timeout = 10,

> > > OOPS should be changed to .max_runtime = 10

> > > > +       .needs_tmpdir = 1,
> > > > +       .cleanup = cleanup,
> > > > +       .test = verify_inotify,
> > > > +       .tcnt = ARRAY_SIZE(tcases),
> > > > +       .tags = (const struct tst_tag[]) {
> > > > +               {"linux-git", "a32e697cda27"},
> > > > +               {}

> > > Missing }

> > > Sorry, I hadn't notice this build failure before posting.

> > No big deal, we can fix this before merge.

> > And we have to try again to decide how to quickly merge tests for rc kernel.

> Right.. forgot about that.
> FWIW, the specific fix of test inotify12 is already in stable kernels
> (v5.10.121, ...)
Correct, I have searched for this before. That means we merge this one very
soon. I'm just waiting if Jan has some comments.

Kind regards,
Petr

> Thanks,
> Amir.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp