ltp.lists.linux.it archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] commands/df01.sh: print more logs when test fails
Date: Fri, 19 Aug 2022 17:27:00 +0200	[thread overview]
Message-ID: <Yv+rxD5EO4MDayXT@pevik> (raw)
In-Reply-To: <f710f7cc103a61c20d5ee907d9717fa384810553.1657198689.git.jstancek@redhat.com>

Hi Jan,

> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>  testcases/commands/df/df01.sh | 5 +++++
>  1 file changed, 5 insertions(+)

> diff --git a/testcases/commands/df/df01.sh b/testcases/commands/df/df01.sh
> index f74032c962e5..6b20f21d0d74 100755
> --- a/testcases/commands/df/df01.sh
> +++ b/testcases/commands/df/df01.sh
> @@ -103,6 +103,11 @@ df_check()

>  	grep ${TST_DEVICE} output | grep -q "${total}.*${used}"
>  	if [ $? -ne 0 ]; then
> +		echo "total: ${total}, used: ${used}"
> +		echo "df saved output:"
I wonder why you didn't use tst_res TINFO? It'd be more readable as the output
can be quite long...
> +		cat output
> +		echo "df output:"
> +		$@

Kind regards,
Petr

>  		return 1
>  	fi
>  }

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-08-19 15:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 12:58 [LTP] [PATCH] commands/df01.sh: print more logs when test fails Jan Stancek
2022-07-08  2:39 ` xuyang2018.jy
2022-07-12  7:40   ` Jan Stancek
2022-08-19 15:27 ` Petr Vorel [this message]
2022-08-20 20:40   ` Jan Stancek
2022-08-22 10:28     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv+rxD5EO4MDayXT@pevik \
    --to=pvorel@suse.cz \
    --cc=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).