From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>,
ltp@lists.linux.it, Li Wang <liwang@redhat.com>,
Richard Palethorpe <rpalethorpe@suse.com>,
Martin Doucha <mdoucha@suse.cz>,
Yang Xu <xuyang2018.jy@fujitsu.com>
Subject: Re: [LTP] [PATCH v5 03/10] tst_supported_fs: Print TCONF if no filesystem supported
Date: Tue, 13 Sep 2022 15:08:18 +0200 [thread overview]
Message-ID: <YyCAwhSvalgj2xrI@pevik> (raw)
In-Reply-To: <YyBNdpiOGeNjVFWs@pevik>
> > Hi!
> > > > Shouldn't we rather than this add tst_res(TCONF, "...") messages to the
> > > > lib/tst_supported_fs_types.c so that we get consistent messages between
> > > > C and shell?
> > > Well, in v4 I add TCONF in tst_fs_is_supported_skiplist()
> > > (lib/tst_supported_fs_types.c), but you asked for TST_FS_UNSUPPORTED [1].
> > I guess that we misunderstand each other. I'm fine with the library
> > printing messages, what I didn't like was the tst_brk() which made the
> > whole program execution flow obscured.
> OK, instead of this from v4:
> > + if (tst_fs_in_skiplist(fs_type, skiplist)) {
> > + tst_brk(TCONF, "%s is not supported by the test",
> > + fs_type);
> I'll add in v6:
> > + if (tst_fs_in_skiplist(fs_type, skiplist)) {
> > + tst_res(TCONF, "%s is not supported by the test",
> > + fs_type);
> > + return TST_FS_UNSUPPORTED;
> > + }
> I'll add tst_res(TINFO, "%s is supported by the test", fs_name);
> from do_test_setup() tst_fs_is_supported_skiplist() and call
> tst_fs_is_supported_skiplist() in do_test_setup().
> But not sure if there can be a cleanup of duplicity of:
> if (!filesystems[0])
> tst_brk(TCONF, "There are no supported filesystems")
In order to unify the API I suggest to move the check above to
tst_get_supported_fs_types() in lib/tst_supported_fs_types.c.
This function is used only on lib/tst_test.c (and will be now in
testcases/lib/tst_supported_fs.c) and uses static array fs_types.
I see no point to add wrapper which would contain this check just to keep
tst_get_supported_fs_types() without tst_brk().
@Cyril WDYT?
Kind regards,
Petr
> Kind regards,
> Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-13 13:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 14:18 [LTP] [PATCH v5 00/10] shell: df01.sh: $TST_ALL_FILESYSTEMS (.all_filesystems) Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 01/10] shell: Print mount command in tst_mount() Petr Vorel
2022-09-12 10:02 ` Cyril Hrubis
2022-09-09 14:18 ` [LTP] [PATCH v5 02/10] shell API/tests: Require root for format/mount tests Petr Vorel
2022-09-12 10:03 ` Cyril Hrubis
2022-09-12 10:12 ` Petr Vorel
2022-09-12 10:24 ` Cyril Hrubis
2022-09-12 11:15 ` Petr Vorel
2022-09-13 13:52 ` Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 03/10] tst_supported_fs: Print TCONF if no filesystem supported Petr Vorel
2022-09-12 14:42 ` Cyril Hrubis
2022-09-12 20:29 ` Petr Vorel
2022-09-13 8:11 ` Cyril Hrubis
2022-09-13 9:29 ` Petr Vorel
2022-09-13 13:08 ` Petr Vorel [this message]
2022-09-09 14:18 ` [LTP] [PATCH v5 04/10] tst_supported_fs: Implement skip list Petr Vorel
2022-09-12 14:39 ` Cyril Hrubis
2022-09-12 20:15 ` Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 05/10] tst_supported_fs: Support skip list when query single fs Petr Vorel
2022-09-12 11:21 ` Petr Vorel
2022-09-12 14:59 ` Cyril Hrubis
2022-09-12 20:38 ` Petr Vorel
2022-09-13 8:14 ` Cyril Hrubis
2022-09-13 9:36 ` Petr Vorel
2022-09-13 10:53 ` Cyril Hrubis
2022-09-13 13:46 ` Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 06/10] shell: Add $TST_SKIP_FILESYSTEMS + tests Petr Vorel
2022-09-12 15:10 ` Cyril Hrubis
2022-09-12 20:43 ` Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 07/10] tst_test.sh: Introduce TST_FS_TYPE_FUSE Petr Vorel
2022-09-12 15:28 ` Cyril Hrubis
2022-09-12 20:04 ` Petr Vorel
2022-09-13 8:15 ` Cyril Hrubis
2022-09-13 8:37 ` Petr Vorel
2022-09-13 14:30 ` Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 08/10] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 09/10] shell: Add tests for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-09 14:18 ` [LTP] [PATCH v5 10/10] df01.sh: Convert to TST_ALL_FILESYSTEMS=1 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyCAwhSvalgj2xrI@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
--cc=rpalethorpe@suse.com \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).