From: Martin Doucha <mdoucha@suse.cz>
To: Petr Vorel <pvorel@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems
Date: Fri, 15 Oct 2021 11:06:44 +0200 [thread overview]
Message-ID: <faee57a0-727e-ae28-590a-290052f79aa3@suse.cz> (raw)
In-Reply-To: <20211015083820.11903-1-pvorel@suse.cz>
Hello,
looks good to me.
Reviewed-by: Martin Doucha <mdoucha@suse.cz>
On 15. 10. 21 10:38, Petr Vorel wrote:
> To make sure bug on XFS is detected on systems which use it.
>
> Due setgid is test problematic on Microsoft filesystems:
>
> creat09.c:81: TBROK: ntfs: Setgid bit not set
> creat09.c:76: TBROK: chown(exfat,65533,4) failed: EPERM (1)
> creat09.c:76: TBROK: chown(vfat,65533,4) failed: EPERM (1)
>
> thus they're disabled.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> changes v3->v4:
> * remove useless .needs_tmpdir
>
> changes v2->v3:
> * add missing dir separator /
> * remove unused SAFE_CHDIR() (was needed due missing /)
> * remove unused <stdio.h>
>
> testcases/kernel/syscalls/creat/creat09.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c
> index 681b80c7d..bed7bddb0 100644
> --- a/testcases/kernel/syscalls/creat/creat09.c
> +++ b/testcases/kernel/syscalls/creat/creat09.c
> @@ -39,7 +39,8 @@
> #define MODE_RWX 0777
> #define MODE_SGID (S_ISGID|0777)
>
> -#define WORKDIR "testdir"
> +#define MNTPOINT "mntpoint"
> +#define WORKDIR MNTPOINT "/testdir"
> #define CREAT_FILE WORKDIR "/creat.tmp"
> #define OPEN_FILE WORKDIR "/open.tmp"
>
> @@ -118,7 +119,15 @@ static struct tst_test test = {
> .setup = setup,
> .cleanup = cleanup,
> .needs_root = 1,
> - .needs_tmpdir = 1,
> + .all_filesystems = 1,
> + .mount_device = 1,
> + .mntpoint = MNTPOINT,
> + .skip_filesystems = (const char*[]) {
> + "exfat",
> + "ntfs",
> + "vfat",
> + NULL
> + },
> .tags = (const struct tst_tag[]) {
> {"linux-git", "0fa3ecd87848"},
> {"CVE", "2018-13405"},
>
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2021-10-15 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 8:38 [LTP] [PATCH v4 1/1] creat09: Run on all_filesystems Petr Vorel
2021-10-15 8:45 ` xuyang2018.jy
2021-10-15 9:01 ` Jan Stancek
2021-10-15 9:35 ` Petr Vorel
2021-10-15 9:06 ` Martin Doucha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faee57a0-727e-ae28-590a-290052f79aa3@suse.cz \
--to=mdoucha@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).