From: Alex Xu via lttng-dev <lttng-dev@lists.lttng.org>
To: lttng-dev@lists.lttng.org
Subject: Re: [PATCH 2/2] Use _umtx_op for futex on FreeBSD
Date: Mon, 27 Jan 2020 19:43:12 +0000 [thread overview]
Message-ID: <158015419247.63624.10811906339754275924@pink> (raw)
In-Reply-To: <1117636152.600695.1580150904852.JavaMail.zimbra@efficios.com>
Quoting Mathieu Desnoyers (2020-01-27 18:48:24)
> Please move the futex_noasync definition after futex_async, considering that
> futex_noasync uses futex_async().
Oops. Fixed that when testing but didn't copy it back to my local copy.
> Also, do you have a link to the API documentation of _umtx_op() ?
> I would like to double-check that all its return values are
> expected by the callers.
https://www.freebsd.org/cgi/man.cgi?query=_umtx_op
I took a look at the man page, the only "interesting" one is EINTR, but
that's the same as Linux.
https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/util/futex.h
doesn't adjust the errno, but it does fiddle with the timeout. I will
add that in the next version.
prev parent reply other threads:[~2020-01-27 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200127182526.22881-1-alex_y_xu.ref@yahoo.ca>
2020-01-27 18:25 ` [PATCH 1/2] Add FreeBSD, DragonFly to syscall-compat.h Alex Xu (Hello71) via lttng-dev
2020-01-27 18:25 ` [PATCH 2/2] Use _umtx_op for futex on FreeBSD Alex Xu (Hello71) via lttng-dev
2020-01-27 18:48 ` Mathieu Desnoyers
2020-01-27 19:43 ` Alex Xu via lttng-dev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158015419247.63624.10811906339754275924@pink \
--to=lttng-dev@lists.lttng.org \
--cc=alex_y_xu@yahoo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).