From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: Norbert Lange <nolange79@gmail.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH] Avoid using the heap for small strings with tracef/tracelog
Date: Thu, 20 May 2021 09:33:38 -0400 (EDT) [thread overview]
Message-ID: <1632491203.52217.1621517618464.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <CADYdroMkj-tsaBBFqnDsRk2cX5DNxO-yYzLpARJzkNx6CRc5jg@mail.gmail.com>
----- On May 20, 2021, at 8:20 AM, Norbert Lange nolange79@gmail.com wrote:
> This patch was intended for 2.12, no src/common/tracer.h there.
You should post feature patches against the master branch. Or if you just
want to send a RFC, and you work on an older branch, please state that the
patch is RFC and which branch the patch is against, but that work won't
be merged unless it's rebased against master.
> Also this patch is brocken, as a va_list cant be iterated twice.
Right. But you could easily do:
va_start() [ first use ] va_end()
then
va_start() [ second use ] va_end(), right ?
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2021-05-20 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 16:56 [lttng-dev] [PATCH] Avoid using the heap for small strings with tracef/tracelog Norbert Lange via lttng-dev
2021-05-19 19:00 ` Mathieu Desnoyers via lttng-dev
2021-05-20 12:20 ` Norbert Lange via lttng-dev
2021-05-20 13:33 ` Mathieu Desnoyers via lttng-dev [this message]
2021-05-20 13:44 ` Norbert Lange via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1632491203.52217.1621517618464.JavaMail.zimbra@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=nolange79@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).