From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: bruce ashfield <bruce.ashfield@gmail.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH] compaction: make tracepoints condtional on CONFIG_COMPACTION
Date: Wed, 17 Aug 2022 11:27:28 -0400 (EDT) [thread overview]
Message-ID: <1671185103.10716.1660750048986.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <CADkTA4NkNEE=kmsiBeJ_UQ7bOZ07CtAEumy8Qfs5cvG=AA1X5Q@mail.gmail.com>
----- On Aug 10, 2022, at 1:48 PM, Bruce Ashfield via lttng-dev lttng-dev@lists.lttng.org wrote:
> On Wed, Aug 10, 2022 at 11:20 AM Michael Jeanson <mjeanson@efficios.com> wrote:
>>
>> On 2022-08-03 15 h 23, Bruce Ashfield via lttng-dev wrote:
>> > Hi all,
>> >
>> > This was found during the update of the yocto project reference
>> > kernel to 5.19. Out of all the supported architectures, only
>> > mips failed during the build of lttng-modules.
>> >
>> > Specifically, it seems like the lack of CONFIG_COMPACTION being
>> > enabled in the kernel was the significant issue. Only one of the
>> > tracepoints blew up, but I can't see how any of them would be
>> > valid in this scenario, or why it would be limited to mips.
>> >
>> > While I don't think this is the right fix, this is what got me
>> > up and passing sanity testing, so I wanted to send the change
>> > and see what the actual, correct fix would be :)
>> >
>> > Cheers,
>> >
>> > Bruce
>>
>> Hi Bruce,
>>
>> Thanks for reporting this issue, I propose a simpler fix [1] of just
>> disabling the build of the compaction probe module when
>> CONFIG_COMPACTION is disabled in the kernel configuration.
>>
>> Can you confirm this patch fixes the issue on your side?
>
> confirmed, it fixes the issue on my side.
Merged into lttng-modules master, stable-2.13, stable-2.12, thanks!
Mathieu
>
> Bruce
>
>>
>> Thanks,
>>
>> Michael
>>
>> [1] https://review.lttng.org/c/lttng-modules/+/8660
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
prev parent reply other threads:[~2022-08-17 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 19:23 [lttng-dev] [PATCH] compaction: make tracepoints condtional on CONFIG_COMPACTION Bruce Ashfield via lttng-dev
2022-08-10 15:20 ` Michael Jeanson via lttng-dev
2022-08-10 17:48 ` Bruce Ashfield via lttng-dev
2022-08-17 15:27 ` Mathieu Desnoyers via lttng-dev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1671185103.10716.1660750048986.JavaMail.zimbra@efficios.com \
--to=lttng-dev@lists.lttng.org \
--cc=bruce.ashfield@gmail.com \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).