* Re: [PATCH lttng-tools] Refactor: remove logically dead code
[not found] <20190920154037.74966-1-jonathan.rajotte-julien@efficios.com>
@ 2019-09-20 21:22 ` Jérémie Galarneau
0 siblings, 0 replies; 2+ messages in thread
From: Jérémie Galarneau @ 2019-09-20 21:22 UTC (permalink / raw)
To: Jonathan Rajotte; +Cc: lttng-dev, jgalar
Merged in master and stable-2.11. Thanks!
Jérémie
On Fri, Sep 20, 2019 at 11:40:37AM -0400, Jonathan Rajotte wrote:
> Fixes coverity #1400681
>
> Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
> ---
> src/common/session-descriptor.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/src/common/session-descriptor.c b/src/common/session-descriptor.c
> index 208eb46ff..713731c3e 100644
> --- a/src/common/session-descriptor.c
> +++ b/src/common/session-descriptor.c
> @@ -550,14 +550,8 @@ lttng_session_descriptor_live_create(
> struct lttng_session_descriptor_live *descriptor;
>
> descriptor = _lttng_session_descriptor_live_create(name, live_timer_us);
> - if (!descriptor) {
> - goto error;
> - }
>
> return descriptor ? &descriptor->base : NULL;
> -error:
> - lttng_session_descriptor_destroy(descriptor ? &descriptor->base : NULL);
> - return NULL;
> }
>
> struct lttng_session_descriptor *
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH lttng-tools] Refactor: remove logically dead code
@ 2019-09-20 15:40 Jonathan Rajotte
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Rajotte @ 2019-09-20 15:40 UTC (permalink / raw)
To: lttng-dev; +Cc: jgalar
Fixes coverity #1400681
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
---
src/common/session-descriptor.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/common/session-descriptor.c b/src/common/session-descriptor.c
index 208eb46ff..713731c3e 100644
--- a/src/common/session-descriptor.c
+++ b/src/common/session-descriptor.c
@@ -550,14 +550,8 @@ lttng_session_descriptor_live_create(
struct lttng_session_descriptor_live *descriptor;
descriptor = _lttng_session_descriptor_live_create(name, live_timer_us);
- if (!descriptor) {
- goto error;
- }
return descriptor ? &descriptor->base : NULL;
-error:
- lttng_session_descriptor_destroy(descriptor ? &descriptor->base : NULL);
- return NULL;
}
struct lttng_session_descriptor *
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-20 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190920154037.74966-1-jonathan.rajotte-julien@efficios.com>
2019-09-20 21:22 ` [PATCH lttng-tools] Refactor: remove logically dead code Jérémie Galarneau
2019-09-20 15:40 Jonathan Rajotte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).