From: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: lttng-dev@lists.lttng.org
Subject: Re: [PATCH] configure.ac: Remove duplicated CMD_DESCR_ROTATE definition
Date: Tue, 26 Nov 2019 15:57:47 -0500 [thread overview]
Message-ID: <20191126205747.GA150252__12434.0624942974$1574801937$gmane$org@gmail.com> (raw)
In-Reply-To: <20190527155246.24102-1-simon.marchi@efficios.com>
Merged in master and stable-2.11.
Thanks!
Jérémie
On Mon, May 27, 2019 at 11:52:46AM -0400, Simon Marchi wrote:
> CMD_DESCR_ROTATE is defined twice by configure. This breaks configuring
> with "-Werror -Wall", as some test programs don't compile due to:
>
> configure:16990: gcc -o conftest -Wall -Werror conftest.c >&5
> conftest.c:163: error: "CONFIG_CMD_DESCR_ROTATE" redefined [-Werror]
> #define CONFIG_CMD_DESCR_ROTATE "Archive a tracing session’s current trace chunk"
>
> conftest.c:154: note: this is the location of the previous definition
> #define CONFIG_CMD_DESCR_ROTATE "Archive a tracing session's current trace chunk"
>
> cc1: all warnings being treated as errors
>
> Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
> ---
> configure.ac | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 214d58ac8856..e88875856115 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -412,7 +412,6 @@ _AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_STATUS], [Get the status of the current t
> _AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_STOP], [Stop tracing])
> _AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_DISABLE_ROTATION], [Unset a rotation schedule])
> _AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_ENABLE_ROTATION], [Set a rotation schedule])
> -_AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_ROTATE], [Archive a tracing session’s current trace chunk])
> _AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_TRACK], [Track specific system resources])
> _AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_UNTRACK], [Untrack specific system resources])
> _AC_DEFINE_QUOTED_AND_SUBST([CMD_DESCR_VERSION], [Show version information])
> --
> 2.21.0
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2019-11-26 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190527155246.24102-1-simon.marchi@efficios.com>
2019-08-20 1:47 ` [PATCH lttng-tools] configure.ac: Remove duplicated CMD_DESCR_ROTATE definition Simon Marchi
[not found] ` <5e19a746-9270-11c1-dd26-24e13a95c359@efficios.com>
2019-11-25 20:00 ` Simon Marchi
2019-11-26 20:57 ` Jérémie Galarneau [this message]
2019-05-27 15:52 [PATCH] " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20191126205747.GA150252__12434.0624942974$1574801937$gmane$org@gmail.com' \
--to=jeremie.galarneau@efficios.com \
--cc=lttng-dev@lists.lttng.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).