From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [PATCH] doc: Fix bind address example for lttng-relayd
Date: Tue, 7 Jan 2020 10:58:43 +0900 [thread overview]
Message-ID: <20200107015843.GA159599__38023.3379358955$1578362357$gmane$org@f3> (raw)
In-Reply-To: <2006658589.17563.1578321593973.JavaMail.zimbra@efficios.com>
On 2020/01/06 09:39, Mathieu Desnoyers wrote:
> ----- On Jan 6, 2020, at 12:19 AM, Benjamin Poirier benjamin.poirier@gmail.com wrote:
>
> > INADDR_ANY is 0.0.0.0
>
> Hi Benjamin,
>
> Double-checking this seems to confirm what the man page states:
>
> % lttng-relayd -b
> % netstat -lnp | grep lttng-relayd
> tcp 0 0 0.0.0.0:5342 0.0.0.0:* LISTEN 4445/lttng-relayd
> tcp 0 0 0.0.0.0:5343 0.0.0.0:* LISTEN 4445/lttng-relayd
> tcp 0 0 127.0.0.1:5344 0.0.0.0:* LISTEN 4445/lttng-relayd
> unix 2 [ ACC ] STREAM LISTENING 56508 4445/lttng-relayd /home/compudj/.lttng/relayd/health-4445
>
> Based on this output, the "live" port of the relayd daemon appears to be listening
> only on 127.0.0.1 by default.
That's right but not relevant to this patch. The part of the man page
changed by this patch is not stating the defaults.
>
> What makes you think the man page needs to be updated ?
The part of the man page changed by this patch is:
If a user is within a secured network and/or has proper firewall
settings, lttng-relayd can listen to LTTng live connections from
all network interfaces by specifying
--live-port=tcp://localhost:5344.
That is incorrect. To listen for connections to all addresses on the host,
the socket has to be bound to INADDR_ANY, 0.0.0.0.
next prev parent reply other threads:[~2020-01-07 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200106051954.138370-1-benjamin.poirier@gmail.com>
2020-01-06 14:39 ` [PATCH] doc: Fix bind address example for lttng-relayd Mathieu Desnoyers
[not found] ` <2006658589.17563.1578321593973.JavaMail.zimbra@efficios.com>
2020-01-07 1:58 ` Benjamin Poirier [this message]
[not found] ` <20200107015843.GA159599@f3>
2020-01-07 16:14 ` Mathieu Desnoyers
2020-01-15 0:45 ` Jérémie Galarneau
2020-01-06 5:19 Benjamin Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20200107015843.GA159599__38023.3379358955$1578362357$gmane$org@f3' \
--to=benjamin.poirier@gmail.com \
--cc=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).