From: "Paul E. McKenney via lttng-dev" <lttng-dev@lists.lttng.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>
Subject: Re: [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256
Date: Wed, 9 Dec 2020 11:38:18 -0800 [thread overview]
Message-ID: <20201209193818.GF2657@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <1681186936.97276.1607538587190.JavaMail.zimbra@efficios.com>
On Wed, Dec 09, 2020 at 01:29:47PM -0500, Mathieu Desnoyers wrote:
> Hi Paul,
>
> Should I merge this temporary fix for liburcu tests, or should we go
> for dynamic allocation of the array right away instead ?
Getting something running now is a good thing. I have occasional access
to a system that could use 512, though. (448 suffices, but powers of
two and all that.)
Longer term, I agree with dynamic allocation.
Thanx, Paul
> Thanks,
>
> Mathieu
>
> ----- On Dec 9, 2020, at 1:15 PM, Michael Jeanson mjeanson@efficios.com wrote:
>
> > Machines with more than 128 CPUs are becomming more common, the proper
> > fix here would be to dynamically allocate the array which we will do,
> > but in the meantime bump the limit to 256 to fix the problem on a 160
> > CPUs ppc64el system where this was reported.
> >
> > Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> > Cc: Paul E. McKenney <paulmck@kernel.org>
> > Change-Id: Ib3cb5d8cb4515e6f626be33c2685fa38cb081782
> > ---
> > tests/common/api.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/common/api.h b/tests/common/api.h
> > index 2b72ec5..b15e588 100644
> > --- a/tests/common/api.h
> > +++ b/tests/common/api.h
> > @@ -108,7 +108,7 @@ static void spin_unlock(spinlock_t *sp)
> >
> > typedef pthread_t thread_id_t;
> >
> > -#define NR_THREADS 128
> > +#define NR_THREADS 256
> >
> > #define __THREAD_ID_MAP_EMPTY ((thread_id_t) 0)
> > #define __THREAD_ID_MAP_WAITING ((thread_id_t) 1)
> > --
> > 2.29.2
>
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
next prev parent reply other threads:[~2020-12-09 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 18:15 [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256 Michael Jeanson via lttng-dev
2020-12-09 18:29 ` Mathieu Desnoyers via lttng-dev
2020-12-09 19:38 ` Paul E. McKenney via lttng-dev [this message]
2020-12-11 18:31 ` Mathieu Desnoyers via lttng-dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209193818.GF2657@paulmck-ThinkPad-P72 \
--to=lttng-dev@lists.lttng.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).