lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
* [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256
@ 2020-12-09 18:15 Michael Jeanson via lttng-dev
  2020-12-09 18:29 ` Mathieu Desnoyers via lttng-dev
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Jeanson via lttng-dev @ 2020-12-09 18:15 UTC (permalink / raw)
  To: lttng-dev; +Cc: Paul E . McKenney

Machines with more than 128 CPUs are becomming more common, the proper
fix here would be to dynamically allocate the array which we will do,
but in the meantime bump the limit to 256 to fix the problem on a 160
CPUs ppc64el system where this was reported.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Cc: Paul E. McKenney <paulmck@kernel.org>
Change-Id: Ib3cb5d8cb4515e6f626be33c2685fa38cb081782
---
 tests/common/api.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/common/api.h b/tests/common/api.h
index 2b72ec5..b15e588 100644
--- a/tests/common/api.h
+++ b/tests/common/api.h
@@ -108,7 +108,7 @@ static void spin_unlock(spinlock_t *sp)
 
 typedef pthread_t thread_id_t;
 
-#define NR_THREADS 128
+#define NR_THREADS 256
 
 #define __THREAD_ID_MAP_EMPTY ((thread_id_t) 0)
 #define __THREAD_ID_MAP_WAITING ((thread_id_t) 1)
-- 
2.29.2

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256
  2020-12-09 18:15 [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256 Michael Jeanson via lttng-dev
@ 2020-12-09 18:29 ` Mathieu Desnoyers via lttng-dev
  2020-12-09 19:38   ` Paul E. McKenney via lttng-dev
  2020-12-11 18:31   ` Mathieu Desnoyers via lttng-dev
  0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Desnoyers via lttng-dev @ 2020-12-09 18:29 UTC (permalink / raw)
  To: paulmck; +Cc: lttng-dev

Hi Paul,

Should I merge this temporary fix for liburcu tests, or should we go
for dynamic allocation of the array right away instead ?

Thanks,

Mathieu

----- On Dec 9, 2020, at 1:15 PM, Michael Jeanson mjeanson@efficios.com wrote:

> Machines with more than 128 CPUs are becomming more common, the proper
> fix here would be to dynamically allocate the array which we will do,
> but in the meantime bump the limit to 256 to fix the problem on a 160
> CPUs ppc64el system where this was reported.
> 
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> Cc: Paul E. McKenney <paulmck@kernel.org>
> Change-Id: Ib3cb5d8cb4515e6f626be33c2685fa38cb081782
> ---
> tests/common/api.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/common/api.h b/tests/common/api.h
> index 2b72ec5..b15e588 100644
> --- a/tests/common/api.h
> +++ b/tests/common/api.h
> @@ -108,7 +108,7 @@ static void spin_unlock(spinlock_t *sp)
> 
> typedef pthread_t thread_id_t;
> 
> -#define NR_THREADS 128
> +#define NR_THREADS 256
> 
> #define __THREAD_ID_MAP_EMPTY ((thread_id_t) 0)
> #define __THREAD_ID_MAP_WAITING ((thread_id_t) 1)
> --
> 2.29.2

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256
  2020-12-09 18:29 ` Mathieu Desnoyers via lttng-dev
@ 2020-12-09 19:38   ` Paul E. McKenney via lttng-dev
  2020-12-11 18:31   ` Mathieu Desnoyers via lttng-dev
  1 sibling, 0 replies; 4+ messages in thread
From: Paul E. McKenney via lttng-dev @ 2020-12-09 19:38 UTC (permalink / raw)
  To: Mathieu Desnoyers; +Cc: lttng-dev

On Wed, Dec 09, 2020 at 01:29:47PM -0500, Mathieu Desnoyers wrote:
> Hi Paul,
> 
> Should I merge this temporary fix for liburcu tests, or should we go
> for dynamic allocation of the array right away instead ?

Getting something running now is a good thing.  I have occasional access
to a system that could use 512, though.  (448 suffices, but powers of
two and all that.)

Longer term, I agree with dynamic allocation.

							Thanx, Paul

> Thanks,
> 
> Mathieu
> 
> ----- On Dec 9, 2020, at 1:15 PM, Michael Jeanson mjeanson@efficios.com wrote:
> 
> > Machines with more than 128 CPUs are becomming more common, the proper
> > fix here would be to dynamically allocate the array which we will do,
> > but in the meantime bump the limit to 256 to fix the problem on a 160
> > CPUs ppc64el system where this was reported.
> > 
> > Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> > Cc: Paul E. McKenney <paulmck@kernel.org>
> > Change-Id: Ib3cb5d8cb4515e6f626be33c2685fa38cb081782
> > ---
> > tests/common/api.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/common/api.h b/tests/common/api.h
> > index 2b72ec5..b15e588 100644
> > --- a/tests/common/api.h
> > +++ b/tests/common/api.h
> > @@ -108,7 +108,7 @@ static void spin_unlock(spinlock_t *sp)
> > 
> > typedef pthread_t thread_id_t;
> > 
> > -#define NR_THREADS 128
> > +#define NR_THREADS 256
> > 
> > #define __THREAD_ID_MAP_EMPTY ((thread_id_t) 0)
> > #define __THREAD_ID_MAP_WAITING ((thread_id_t) 1)
> > --
> > 2.29.2
> 
> -- 
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256
  2020-12-09 18:29 ` Mathieu Desnoyers via lttng-dev
  2020-12-09 19:38   ` Paul E. McKenney via lttng-dev
@ 2020-12-11 18:31   ` Mathieu Desnoyers via lttng-dev
  1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Desnoyers via lttng-dev @ 2020-12-11 18:31 UTC (permalink / raw)
  To: Michael Jeanson; +Cc: lttng-dev, paulmck

Hi Michael,

After discussion with Paul, we can go for bumping the max nr cpu limit
of this test to 4096.

1536 would cover all the current hardware Paul E. McKenney is aware of.
4096 would cover all hardware he has ever received a bug report on.

Can you try it out and submit an updated patch ?

Thanks,

Mathieu

----- On Dec 9, 2020, at 1:29 PM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:

> Hi Paul,
> 
> Should I merge this temporary fix for liburcu tests, or should we go
> for dynamic allocation of the array right away instead ?
> 
> Thanks,
> 
> Mathieu
> 
> ----- On Dec 9, 2020, at 1:15 PM, Michael Jeanson mjeanson@efficios.com wrote:
> 
>> Machines with more than 128 CPUs are becomming more common, the proper
>> fix here would be to dynamically allocate the array which we will do,
>> but in the meantime bump the limit to 256 to fix the problem on a 160
>> CPUs ppc64el system where this was reported.
>> 
>> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
>> Cc: Paul E. McKenney <paulmck@kernel.org>
>> Change-Id: Ib3cb5d8cb4515e6f626be33c2685fa38cb081782
>> ---
>> tests/common/api.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/tests/common/api.h b/tests/common/api.h
>> index 2b72ec5..b15e588 100644
>> --- a/tests/common/api.h
>> +++ b/tests/common/api.h
>> @@ -108,7 +108,7 @@ static void spin_unlock(spinlock_t *sp)
>> 
>> typedef pthread_t thread_id_t;
>> 
>> -#define NR_THREADS 128
>> +#define NR_THREADS 256
>> 
>> #define __THREAD_ID_MAP_EMPTY ((thread_id_t) 0)
>> #define __THREAD_ID_MAP_WAITING ((thread_id_t) 1)
>> --
>> 2.29.2
> 
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-11 18:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 18:15 [lttng-dev] [PATCH urcu] fix: bump tests thread limit to 256 Michael Jeanson via lttng-dev
2020-12-09 18:29 ` Mathieu Desnoyers via lttng-dev
2020-12-09 19:38   ` Paul E. McKenney via lttng-dev
2020-12-11 18:31   ` Mathieu Desnoyers via lttng-dev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).