lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Junchang Wang <junchangwang@gmail.com>
Cc: lttng-dev <lttng-dev@lists.lttng.org>, paulmck <paulmck@linux.ibm.com>
Subject: Re: [PATCH v2 1/4] userspace-rcu: Add lock-free singly linked list rculflist
Date: Mon, 29 Jul 2019 09:45:24 -0400 (EDT)	[thread overview]
Message-ID: <2135438495.917.1564407924224.JavaMail.zimbra__41842.3551179998$1564407953$gmane$org@efficios.com> (raw)
In-Reply-To: <1564407331-25820-2-git-send-email-junchangwang@gmail.com>

----- On Jul 29, 2019, at 9:35 AM, Junchang Wang junchangwang@gmail.com wrote:

> Signed-off-by: Junchang Wang <junchangwang@gmail.com>

Hi Junchang,

Thanks for submitting this! I've been on vacation for the past two weeks,
hence the delay in reply.

A few points:

I think we should move the implementation of find/insert/delete to a .c
file (rather than headers) because at least two of those functions are
larger than 10 lines, and therefore don't fall under the "trivial"
category.

I also notice that the implementation you propose is GPLv2+. Would you
be willing to re-license your contribution under LGPLv2.1 or LGPLv2.1+ ?
This is the license we use for the entire Userspace RCU library. liburcu
is meant to be used by non-GPL/LGPL programs as well.

I'll wait until I get an answer from you on those points before digging
further into the code.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

  parent reply	other threads:[~2019-07-29 13:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1564407331-25820-1-git-send-email-junchangwang@gmail.com>
2019-07-29 13:35 ` [PATCH v2 1/4] userspace-rcu: Add lock-free singly linked list rculflist Junchang Wang
2019-07-29 13:35 ` [PATCH v2 2/4] userspace-rcu: Add sample code of rculflist Junchang Wang
2019-07-29 13:35 ` [PATCH v2 3/4] userspace-rcu: Update Makefile.am to include rculflist into the project Junchang Wang
2019-07-29 13:35 ` [PATCH v2 4/4] userspace-rcu: Add a brief description of rculflist in cds-api.md Junchang Wang
     [not found] ` <1564407331-25820-2-git-send-email-junchangwang@gmail.com>
2019-07-29 13:45   ` Mathieu Desnoyers [this message]
2019-07-29 13:55 ` [PATCH v2 0/4] userspace-rcu: Add lock-free, ordered singly linked list Mathieu Desnoyers
     [not found] ` <1759632476.1182.1564408558415.JavaMail.zimbra@efficios.com>
2019-07-30 13:34   ` Junchang Wang
     [not found]   ` <CABoNC821qnePU4Enrs8mSseVq-_Hp3Cehh93DO0+s=cKtDTZXQ@mail.gmail.com>
2019-07-30 15:15     ` Mathieu Desnoyers
     [not found]     ` <2090901729.4706.1564499733170.JavaMail.zimbra@efficios.com>
2019-08-01 10:51       ` Junchang Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='2135438495.917.1564407924224.JavaMail.zimbra__41842.3551179998$1564407953$gmane$org@efficios.com' \
    --to=mathieu.desnoyers@efficios.com \
    --cc=junchangwang@gmail.com \
    --cc=lttng-dev@lists.lttng.org \
    --cc=paulmck@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).